pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart - Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart

Issue 24276010: Change package scheduled_test to throw TestFailures rather than strings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Also in async_test.dart Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart ('k') | pkg/scheduled_test/lib/src/descriptor/pattern_descriptor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart

diff --git a/pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart b/pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart

index 8a80be259c092762562e9c2cb5f1825d7d72c7f7..590a1ce140afe3c32c750ded8664fbbdae2c5fe3 100644

--- a/pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart

+++ b/pkg/scheduled_test/lib/src/descriptor/nothing_descriptor.dart

@@ -27,10 +27,9 @@ class NothingDescriptor extends Descriptor {

if (parent == null) parent = defaultRoot;

var fullPath = path.join(parent, name);

if (new File(fullPath).existsSync()) {

- throw "Expected nothing to exist at '$fullPath', but found a file.";

+ fail("Expected nothing to exist at '$fullPath', but found a file.");

} else if (new Directory(fullPath).existsSync()) {

- throw "Expected nothing to exist at '$fullPath', but found a "

- "directory.";

+ fail("Expected nothing to exist at '$fullPath', but found a directory.");

} else {

return;

}