Change package scheduled_test to throw TestFailures rather than strings.

pkg/scheduled_test/test/scheduled_process_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library scheduled_process_test;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
@@ skipping 125 matching lines @@
 
     test('test 2', () {
       expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
       expect(errors.length, anyOf(1, 2));
       expect(errors[0].error, isStateError);
       expect(errors[0].error.message, equals("No elements"));
 
       // Whether or not this error appears depends on how quickly the "no
       // elements" error is handled.
       if (errors.length == 2) {
-        expect(errors[1].error, matches(r"^Process "
+        expect(errors[1].error, new isInstanceOf<TestFailure>());
+        expect(errors[1].error.message, matches(r"^Process "
             r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
             r"exit code 0\."));
       }
     });
   }, passing: ['test 2']);
 
   expectTestsPass("a process that ends during the task immediately before it's "
       "scheduled to end shouldn't cause an error", () {
     test('test', () {
       var process = startDartProcess('stdin.toList();');
@@ skipping 32 matching lines @@
 
     test('test 2', () {
       expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
       expect(errors.length, anyOf(1, 2));
       expect(errors[0].error, isStateError);
       expect(errors[0].error.message, equals("No elements"));
 
       // Whether or not this error appears depends on how quickly the "no
       // elements" error is handled.
       if (errors.length == 2) {
-        expect(errors[1].error, matches(r"^Process "
+        expect(errors[1].error, new isInstanceOf<TestFailure>());
+        expect(errors[1].error.message, matches(r"^Process "
             r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
             r"exit code 0\."));
       }
     });
   }, passing: ['test 2']);
 
   expectTestsPass("nextErrLine returns the next line of stderr from the "
       "process", () {
     test('test', () {
       var process = startDartProcess(r'''
@@ skipping 23 matching lines @@
 
     test('test 2', () {
       expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
       expect(errors.length, anyOf(1, 2));
       expect(errors[0].error, isStateError);
       expect(errors[0].error.message, equals("No elements"));
 
       // Whether or not this error appears depends on how quickly the "no
       // elements" error is handled.
       if (errors.length == 2) {
-        expect(errors[1].error, matches(r"^Process "
+        expect(errors[1].error, new isInstanceOf<TestFailure>());
+        expect(errors[1].error.message, matches(r"^Process "
             r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
             r"exit code 0\."));
       }
     });
   }, passing: ['test 2']);
 
   expectTestsPass("remainingStdout returns all the stdout if it's not consumed "
       "any other way", () {
     test('test', () {
       var process = startDartProcess(r'print("hello\n\nworld"); print("hi");');
@@ skipping 130 matching lines @@
 
   currentSchedule.onComplete.schedule(() {
     return tempDir.catchError((_) => null).then((dir) {
       if (dir == null) return;
       return new Directory(dir).delete(recursive: true);
     });
   }, 'clean up temp dir');
 
   return new ScheduledProcess.start(dartExecutable, ['--checked', dartPath]);
 }