Change package scheduled_test to throw TestFailures rather than strings.

pkg/scheduled_test/test/descriptor/directory_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:path/path.dart' as path;
 import 'package:scheduled_test/descriptor.dart' as d;
 import 'package:scheduled_test/scheduled_test.dart';
@@ skipping 109 matching lines @@
           d.file('subfile2.txt', 'subcontents2')
         ]),
         d.file('file1.txt', 'contents1'),
         d.file('file2.txt', 'contents2')
       ]).validate();
     });
 
     test('test 2', () {
       expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
       expect(errors.length, equals(1));
+      // Error is _DirectoryValidationError.

[nweiz, 2013/09/20 21:45:41]

I don't think these comments are useful. The tests are written from the
perspective of a user of the library, who wouldn't know about the type of the
exception.

[Bill Hesse, 2013/09/23 17:15:25]

Done.

       expect(errors.first.error.toString(),
           matches(r"^Directory not found: '[^']+[\\/]dir[\\/]subdir'\.$"));
     });
   }, passing: ['test 2']);
 
   expectTestsPass("directory().validate() fails if a file isn't found", () {
     var errors;
     test('test 1', () {
       scheduleSandbox();
 
@@ skipping 22 matching lines @@
           d.file('subfile2.txt', 'subcontents2')
         ]),
         d.file('file1.txt', 'contents1'),
         d.file('file2.txt', 'contents2')
       ]).validate();
     });
 
     test('test 2', () {
       expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
       expect(errors.length, equals(1));
+      // Error is a _DirectoryValidationError.
       expect(errors.first.error.toString(),
           matches(r"^File not found: '[^']+[\\/]dir[\\/]file2\.txt'\.$"));
     });
   }, passing: ['test 2']);
 
   expectTestsPass("directory().validate() fails if multiple children aren't "
       "found or have the wrong contents", () {
     var errors;
     test('test 1', () {
       scheduleSandbox();
@@ skipping 111 matching lines @@
 
   expectTestsPass("directory().load() fails to load a nested directory", () {
     test('test', () {
       var dir = d.dir('dir', [
         d.dir('subdir', [
           d.file('name.txt', 'subcontents')
         ]),
         d.file('name.txt', 'contents')
       ]);
 
-      expect(dir.load('subdir').toList(),
-          throwsA(equals("Couldn't find a readable entry named 'subdir' within "
-              "'dir'.")));
+      expect(dir.load('subdir').toList(), throwsA(allOf(
+          new isInstanceOf<TestFailure>(),
+          predicate((x) => x.message ==
+              "Couldn't find a readable entry named 'subdir' within 'dir'."))));
     });
   });
 
   expectTestsPass("directory().load() fails to load an absolute path", () {
     test('test', () {
       var dir = d.dir('dir', [d.file('name.txt', 'contents')]);
 
       expect(dir.load('/name.txt').toList(), throwsArgumentError);
     });
   });
 
   expectTestsPass("directory().load() fails to load '.', '..', or ''", () {
     test('test', () {
       var dir = d.dir('dir', [d.file('name.txt', 'contents')]);
 
       expect(dir.load('.').toList(), throwsArgumentError);
 
       expect(dir.load('..').toList(), throwsArgumentError);
 
       expect(dir.load('').toList(), throwsArgumentError);
     });
   });
 
   expectTestsPass("directory().load() fails to load a file that doesn't exist",
       () {
     test('test', () {
       var dir = d.dir('dir', [d.file('name.txt', 'contents')]);
 
-      expect(dir.load('not-name.txt').toList(),
-          throwsA(equals("Couldn't find a readable entry named 'not-name.txt' "
-              "within 'dir'.")));
+      expect(dir.load('not-name.txt').toList(), throwsA(allOf(
+          new isInstanceOf<TestFailure>(),
+          predicate((x) => x.message == "Couldn't find a readable entry "
+                                        "named 'not-name.txt' within 'dir'."))));
     });
   });
 
   expectTestsPass("directory().load() fails to load a file that exists "
       "multiple times", () {
     test('test', () {
       var dir = d.dir('dir', [
         d.file('name.txt', 'contents'),
         d.file('name.txt', 'contents')
       ]);
 
-      expect(dir.load('name.txt').toList(),
-          throwsA(equals("Found multiple readable entries named 'name.txt' "
-              "within 'dir'.")));
+      expect(dir.load('name.txt').toList(), throwsA(allOf(
+          new isInstanceOf<TestFailure>(),
+          predicate((x) => x.message ==
+              "Found multiple readable entries named 'name.txt' within 'dir'."))));
     });
   });
 
   expectTestsPass("directory().load() loads a file next to a subdirectory with "
       "the same name", () {
     test('test', () {
       var dir = d.dir('dir', [
         d.file('name', 'contents'),
         d.dir('name', [d.file('subfile', 'contents')])
       ]);
@@ skipping 44 matching lines @@
           "'-- file2.txt"));
     });
   });
 
   expectTestsPass("directory().describe() with no contents returns the "
       "directory name", () {
     test('test', () {
       expect(d.dir('dir').describe(), equals('dir'));
     });
   });
-}
+}