third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-onload-event.html - Issue 2427553002: Fix XHR's logic to determine whether or not to dispatch upload progress events

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-onload-event.html

Issue 2427553002: Fix XHR's logic to determine whether or not to dispatch upload progress events

Patch Set: a Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-progress-events-handlers-must-be-set-before-send.html » ('j') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/testharness.js"></script>	4 <script src="../resources/testharness.js"></script>

5 <script src="../resources/testharnessreport.js"></script>	5 <script src="../resources/testharnessreport.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <div id="log"></div>

9 <script type="text/javascript">	8 <script type="text/javascript">

10	9

11 var xhr;	10 var xhr;

12 var payload = "data";	11 var payload = "data";

13 var expectedLength = payload.length;	12 var expectedLength = payload.length;

14	13

15 function verifyProgressEvent(eventName, e, expected)	14 function verifyProgressEvent(eventName, e, expected)

16 {	15 {

17 assert_true(e.lengthComputable);	16 assert_true(e.lengthComputable);

18 assert_equals(e.loaded, expected, "Expected 'loaded' value of '" + eventName + "' event.");	17 assert_equals(e.loaded, expected, "Expected 'loaded' value of '" + eventName + "' event.");

(...skipping 10 matching lines...) Expand all Loading...
29 var testUploadLoadEvent = async_test("Check that upload 'load' events are delive red and have expected values.");	28 var testUploadLoadEvent = async_test("Check that upload 'load' events are delive red and have expected values.");

30 testUploadLoadEvent.step(function () {	29 testUploadLoadEvent.step(function () {

31 xhr = new XMLHttpRequest();	30 xhr = new XMLHttpRequest();

32 xhr.upload.onload = testUploadLoadEvent.step_func(loadHandler);	31 xhr.upload.onload = testUploadLoadEvent.step_func(loadHandler);

33 xhr.open("POST", "resources/post-echo.php", true);	32 xhr.open("POST", "resources/post-echo.php", true);

34 xhr.send(payload);	33 xhr.send(payload);

35 });	34 });

36 </script>	35 </script>

37 </body>	36 </body>

38 </html>	37 </html>

OLD	NEW