Issue 2427503002: Also mark the script-scope for eager compilation upon ForceEagerCompilation

Issue 2427503002: Also mark the script-scope for eager compilation upon ForceEagerCompilation (Closed)

Created:
4 years, 2 months ago by Toon Verwaest

Modified:
4 years, 2 months ago

Reviewers:
marja

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Also mark the script-scope for eager compilation upon ForceEagerCompilation BUG=v8:5424 Committed: https://crrev.com/9126cb8d2a667ecfb343e496298bd541369a2746 Cr-Commit-Position: refs/heads/master@{#40338}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/ast/scopes.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 8 (3 generated)

marja

lgtm But what difference does this make, isn't top level code always eagerly compiled?

4 years, 2 months ago (2016-10-17 07:48:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427503002/1

4 years, 2 months ago (2016-10-17 08:06:36 UTC) #5

commit-bot: I haz the power

4 years, 2 months ago (2016-10-17 08:32:14 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9126cb8d2a667ecfb343e496298bd541369a2746
Cr-Commit-Position: refs/heads/master@{#40338}