Reland "Leak reports collect information about the last uptrend"

Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352
Committed: https://crrev.com/90a2477a77b011177eca80a405c1a7f1a4022de7
Cr-Commit-Position: refs/heads/master@{#426048}

[Simon Que, 2016-10-18 00:35:47]

sque@chromium.org changed reviewers:
+ asvitkine@chromium.org, wfh@chromium.org

[Simon Que, 2016-10-18 00:35:48]

+wfh to review 	components/metrics/leak_detector/leak_detector.mojom

+asvitkine to review 	components/metrics/proto/memory_leak_report.proto

I am an OWNER for all other changed files.

[Alexei Svitkine (slow), 2016-10-18 14:31:09]

lgtm

[Will Harris, 2016-10-18 19:31:25]

lgtm for components/metrics/leak_detector/leak_detector.mojom

[Simon Que, 2016-10-18 19:57:06]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2016-10-18 19:57:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Will Harris, 2016-10-18 21:00:54]

Description was changed from

==========
Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352
==========

to

==========
Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352
==========

[Will Harris, 2016-10-18 21:01:07]

Although you are an owner of the other nine files, you still should get a review
and an l-g-t-m (from any chromium contributor, not just limited to owners of
leak_detector) before committing, since every commit to chromium should have at
least one reviewer. Perhaps grt could review as this looks right up his street.
:)

[Alexei Svitkine (slow), 2016-10-18 21:03:55]

However, since this is a re-land of a CL, it's fine to get just one person
to review the diff from the original one and TBR the reviewers who reviewed
the original landing - assuming the original CL had good coverage.

On Tue, Oct 18, 2016 at 5:01 PM, <wfh@chromium.org> wrote:

> Although you are an owner of the other nine files, you still should get a
> review
> and an l-g-t-m (from any chromium contributor, not just limited to owners
> of
> leak_detector) before committing, since every commit to chromium should
> have at
> least one reviewer. Perhaps grt could review as this looks right up his
> street.
> :)
>
> https://codereview.chromium.org/2427493004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Will Harris, 2016-10-18 21:18:33]

Sure. is ps1 the original CL, in which case the change between ps1 and ps2 lgtm

[commit-bot: I haz the power, 2016-10-18 21:24:17]

Description was changed from

==========
Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352
==========

to

==========
Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352
==========

[commit-bot: I haz the power, 2016-10-18 21:24:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:03:09]

Description was changed from

==========
Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352
==========

to

==========
Reland "Leak reports collect information about the last uptrend"

Leak reports collect information about the last uptrend in the number
of allocations for a given call stack. Changes include new public methods in
CallStackTable, new fields in LeakDetectorImpl::LeakReport and the mojo
structs, minor changes in LeakDetector and LeakDetectorImpl, and updates in
unit tests for CallStackTable and protobuf_to_mojo_converter.

- Reverted in https://codereview.chromium.org/2417403002
- Additional fix: Correct the allocator type

BUG=650352

Committed: https://crrev.com/90a2477a77b011177eca80a405c1a7f1a4022de7
Cr-Commit-Position: refs/heads/master@{#426048}
==========

[commit-bot: I haz the power, 2016-10-21 13:03:10]

Patchset 2 (id:??) landed as
https://crrev.com/90a2477a77b011177eca80a405c1a7f1a4022de7
Cr-Commit-Position: refs/heads/master@{#426048}