Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2427493002: [wrapper-tracing] Clear reporter after lazy cleanup (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
Reviewers:
haraken, Marcel Hlopko
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Clear reporter after lazy cleanup Fixes the crasher in DCHECK(!m_reporter) on the trace wrappables fyi bot. BUG=chromium:656276 R=haraken@chromium.org,hlopko@chromium.org Committed: https://crrev.com/da671132ddc13821713064b41ca4b65cd7e44865 Cr-Commit-Position: refs/heads/master@{#425642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Lippautz
4 years, 2 months ago (2016-10-17 07:26:04 UTC) #1
haraken
LGTM
4 years, 2 months ago (2016-10-17 07:33:11 UTC) #4
Marcel Hlopko
lgtm
4 years, 2 months ago (2016-10-17 07:41:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427493002/1
4 years, 2 months ago (2016-10-17 09:23:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 09:29:48 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:32:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da671132ddc13821713064b41ca4b65cd7e44865
Cr-Commit-Position: refs/heads/master@{#425642}

Powered by Google App Engine
This is Rietveld 408576698