Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2427443002: Replace remaining shell references with service manager (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dcheng, feature-media-reviews_chromium.org, jam, kalyank, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, shuchen+watch_chromium.org, James Su, tfarina, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace remaining shell references with service manager This covers service and capability names, filenames, target names, test names, variable names, and most occurrences in documentation. TBRs because it's just renames. BUG=None TBR=ben@chromium.org TBR=dcheng@chromium.org Committed: https://crrev.com/3860a8520462b4a8dcd887890f8893ee38d7e2d8 Cr-Commit-Position: refs/heads/master@{#425617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -1429 lines) Patch
M ash/autoclick/mus/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch_hud/mus/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/chrome_mash_manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/mash/mash_runner.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/base/mash_browser_tests_manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/base/mojo_test_connector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 7 chunks +16 lines, -14 lines 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/service_manager/child_connection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/service_manager/embedded_service_runner.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 2 chunks +6 lines, -4 lines 0 comments Download
M content/public/app/mojo/content_gpu_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/mojo/content_plugin_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/mojo/content_utility_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/init/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M mash/login/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mash/task_viewer/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/README.md View 2 chunks +2 lines, -2 lines 0 comments Download
M services/catalog/catalog.h View 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/manifest.json View 1 chunk +5 lines, -2 lines 0 comments Download
M services/catalog/reader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/navigation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/manifest.json View 1 chunk +5 lines, -3 lines 0 comments Download
M services/service_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/background/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/service_manager/background/background_service_manager.h View 4 chunks +12 lines, -11 lines 0 comments Download
A + services/service_manager/background/background_service_manager.cc View 5 chunks +16 lines, -15 lines 0 comments Download
A + services/service_manager/background/background_service_manager_main.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/service_manager/background/background_service_manager_main.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/service_manager/background/background_shell.h View 1 chunk +0 lines, -69 lines 0 comments Download
D services/service_manager/background/background_shell.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D services/service_manager/background/background_shell_main.h View 1 chunk +0 lines, -12 lines 0 comments Download
D services/service_manager/background/background_shell_main.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M services/service_manager/background/tests/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments Download
A + services/service_manager/background/tests/background_service_manager_unittest.cc View 4 chunks +12 lines, -11 lines 0 comments Download
D services/service_manager/background/tests/background_shell_unittest.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M services/service_manager/background/tests/test_catalog_store.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/service_manager/background/tests/test_manifest.json View 1 chunk +4 lines, -4 lines 0 comments Download
M services/service_manager/background/tests/test_service_manifest.json View 1 chunk +3 lines, -3 lines 0 comments Download
M services/service_manager/manifest.json View 2 chunks +11 lines, -9 lines 0 comments Download
M services/service_manager/native_runner.h View 1 chunk +4 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/connection.h View 3 chunks +13 lines, -11 lines 0 comments Download
M services/service_manager/public/cpp/connector.h View 1 chunk +11 lines, -8 lines 0 comments Download
M services/service_manager/public/cpp/lib/connector_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/lib/service_test.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M services/service_manager/public/cpp/names.h View 2 chunks +3 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/service_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/service_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/test/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/service_manager/public/cpp/test/run_all_service_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/service_manager/public/cpp/test/run_all_shelltests.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M services/service_manager/public/interfaces/connector.mojom View 2 chunks +59 lines, -58 lines 0 comments Download
M services/service_manager/public/interfaces/service.mojom View 3 chunks +8 lines, -8 lines 0 comments Download
M services/service_manager/runner/common/client_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/service_manager/runner/host/child_process_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/service_manager/runner/host/child_process_host_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/service_manager/runner/host/mach_broker.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/service_manager/runner/host/mach_broker.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/service_manager.cc View 7 chunks +24 lines, -19 lines 0 comments Download
M services/service_manager/standalone/context.h View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/standalone/context.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M services/service_manager/standalone/desktop/launcher_process.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/service_manager/standalone/desktop/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/standalone/desktop/main_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/service_manager/standalone/desktop/main_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_test_class_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_test_package_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_test_singleton_app_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M services/service_manager/tests/connect/connect_unittests_manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
A + services/service_manager/tests/lifecycle/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M services/service_manager/tests/lifecycle/app_client.h View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/app_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/lifecycle_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M services/service_manager/tests/lifecycle/lifecycle_unittest.mojom View 2 chunks +11 lines, -11 lines 0 comments Download
M services/service_manager/tests/lifecycle/lifecycle_unittest_manifest.json View 1 chunk +4 lines, -4 lines 0 comments Download
M services/service_manager/tests/lifecycle/package.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M services/service_manager/tests/lifecycle/package_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
A + services/service_manager/tests/service_manager/BUILD.gn View 5 chunks +11 lines, -11 lines 0 comments Download
A + services/service_manager/tests/service_manager/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/service_manager/tests/service_manager/driver.cc View 4 chunks +10 lines, -10 lines 0 comments Download
A services/service_manager/tests/service_manager/driver_manifest.json View 1 chunk +16 lines, -0 lines 0 comments Download
A + services/service_manager/tests/service_manager/service_manager_unittest.cc View 8 chunks +27 lines, -33 lines 0 comments Download
A + services/service_manager/tests/service_manager/service_manager_unittest.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A services/service_manager/tests/service_manager/service_manager_unittest_manifest.json View 1 chunk +18 lines, -0 lines 0 comments Download
A + services/service_manager/tests/service_manager/target.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A services/service_manager/tests/service_manager/target_manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download
D services/service_manager/tests/shell/BUILD.gn View 1 chunk +0 lines, -102 lines 0 comments Download
D services/service_manager/tests/shell/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/service_manager/tests/shell/driver.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D services/service_manager/tests/shell/driver_manifest.json View 1 chunk +0 lines, -14 lines 0 comments Download
D services/service_manager/tests/shell/shell_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D services/service_manager/tests/shell/shell_unittest.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D services/service_manager/tests/shell/shell_unittest_manifest.json View 1 chunk +0 lines, -16 lines 0 comments Download
D services/service_manager/tests/shell/target.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D services/service_manager/tests/shell/target_manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
M services/service_manager/tests/shutdown/shutdown_client_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/shutdown/shutdown_service_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/shutdown/shutdown_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/service_manager/tests/shutdown/shutdown_unittest_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/util.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/tracing/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/public/interfaces/tracing.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M services/tracing/service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/service.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M services/ui/clipboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + services/ui/common/run_all_service_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/ui/common/run_all_shelltests.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M services/ui/demo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ime/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M services/ui/ws/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/service_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_service.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/views_mus_test_suite.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 7 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427443002/1
4 years, 2 months ago (2016-10-17 03:38:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 04:57:56 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 05:00:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3860a8520462b4a8dcd887890f8893ee38d7e2d8
Cr-Commit-Position: refs/heads/master@{#425617}

Powered by Google App Engine
This is Rietveld 408576698