Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2427413006: Revert "Enable subframe FrameNavigationEntries by default." (Closed)

Created:
4 years, 2 months ago by Charlie Reis
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable subframe FrameNavigationEntries by default." This reverts commit 111baab648276f64b58d7af5b3f47fd3823dc42e. As a result, we fall back to using the old navigation path (including HistoryController) unless an OOPIF or PlzNavigate mode is enabled. BUG=236848, 657896 TEST=See bug 657896 for repro steps. [Closed, since this had failures and we've landed a fix in r426880]

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/site_isolation_policy.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (5 generated)
Charlie Reis
The CQ bit was checked by creis@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-20 20:22:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427413006/1
4 years, 2 months ago (2016-10-20 20:23:10 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-20 21:04:40 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/319507)
4 years, 2 months ago (2016-10-20 21:04:41 UTC) #4
Charlie Reis
4 years, 2 months ago (2016-10-21 21:12:44 UTC) #5 
Description was changed from

==========
Revert "Enable subframe FrameNavigationEntries by default."

This reverts commit 111baab648276f64b58d7af5b3f47fd3823dc42e.

As a result, we fall back to using the old navigation path (including
HistoryController) unless an OOPIF or PlzNavigate mode is enabled.

BUG=236848, 657896
TEST=See bug 657896 for repro steps.
==========

to

==========
Revert "Enable subframe FrameNavigationEntries by default."

This reverts commit 111baab648276f64b58d7af5b3f47fd3823dc42e.

As a result, we fall back to using the old navigation path (including
HistoryController) unless an OOPIF or PlzNavigate mode is enabled.

BUG=236848, 657896
TEST=See bug 657896 for repro steps.

[Closed, since this had failures and we've landed a fix in r426880]
==========

Powered by Google App Engine
This is Rietveld 408576698