gm/rebaseline_server/static/view.html - Issue 24274003: Create HTTP-based GM results viewer.

Side by Side Diff: gm/rebaseline_server/static/view.html

Issue 24274003: Create HTTP-based GM results viewer. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: svn_py Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <html ng-app="Loader">

	4

	5 <head>

	6 <title>Current GM Failures</title>

	7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script>

	8 <script src="loader.js"></script>

	9 </head>

	10

	11 <body>
	borenet 2013/09/25 15:09:51 For some reason, I'm really thrown off by this web For some reason, I'm really thrown off by this webpage's not being centered. Leaving that decision up to you. epoger 2013/09/25 16:21:18 I tried to make some adjustments, but my CSS-fu is Show quoted text On 2013/09/25 15:09:51, borenet wrote: > For some reason, I'm really thrown off by this webpage's not being centered. > Leaving that decision up to you. I tried to make some adjustments, but my CSS-fu is weak. I would rather leave these stylistic adjustments for a future CL, if that's OK with you. borenet 2013/09/25 19:28:17 SGTM Show quoted text On 2013/09/25 16:21:18, epoger wrote: > On 2013/09/25 15:09:51, borenet wrote: > > For some reason, I'm really thrown off by this webpage's not being centered. > > Leaving that decision up to you. > > I tried to make some adjustments, but my CSS-fu is weak. I would rather leave > these stylistic adjustments for a future CL, if that's OK with you. SGTM
	12 <div ng-controller="Loader.Controller" >

	13

	14 Settings:

	15 <ul>

	16 <li>show results of type

	17 <select ng-model="resultType"

	18 ng-init="resultType='failed';changeResultType()"

	19 ng-change="changeResultType()">

	20 <option>failed</option>

	21 <option>failure-ignored</option>

	22 <option>no-comparison</option>

	23 </select>

	24 </li>

	25 <li>image size

	26 <input type="text" ng-model="imageSize" ng-init="imageSize=100"

	27 maxlength="4"/>

	28 </li>

	29 </ul>

	30

	31 <p>

	32 <table border="1">

	33 <tr>

	34 <th ng:click="sortColumn='builder'">Builder</th>

	35 <th ng:click="sortColumn='test'">Test</th>

	36 <th ng:click="sortColumn='config'">Config</th>

	37 <th ng:click="sortColumn='expectedHashDigest'">Expected Image</th>

	38 <th ng:click="sortColumn='actualHashDigest'">Actual Image</th>
	borenet 2013/09/25 15:09:51 I don't know how useful they were to other devs, b I don't know how useful they were to other devs, but I find myself missing the diff images. I'm aware that we aren't generating them any more though. epoger 2013/09/25 16:21:18 Oh, absolutely. I added a TODO in lamenting this Show quoted text On 2013/09/25 15:09:51, borenet wrote: > I don't know how useful they were to other devs, but I find myself missing the > diff images. I'm aware that we aren't generating them any more though. Oh, absolutely. I added a TODO in lamenting this missing column. I can think of two ways of generating these pixel diffs: 1. Make results.py download the images themselves, calculate pixel diffs, and provide them to the client (perhaps as inline image data, within the JSON file?) 2. Make the client download the images into Canvas elements, and then calculate the pixel diffs as the user scrolls to them. This has several advantages (including making it possible to do nifty effects like a loupe), but due to security constraints requires the images to be loaded from the same domain as the JSON results themselves. My intent is to add a new dispatcher to server.py : if the client requests /images/gm/bitmap-64bitMD5/imageblur/5680959140053860741.png , fetch that file from under http://chromium-skia-gm.commondatastorage.googleapis.com/ and return it to the client. That will allow us to work around the security constraint, and the client can perform Canvas operations on the fetched image data. Thoughts? epoger 2013/09/25 18:26:33 Brian has changed my mind about this. I now think Show quoted text On 2013/09/25 16:21:18, epoger wrote: > On 2013/09/25 15:09:51, borenet wrote: > > I don't know how useful they were to other devs, but I find myself missing the > > diff images. I'm aware that we aren't generating them any more though. > > Oh, absolutely. I added a TODO in lamenting this missing column. > > I can think of two ways of generating these pixel diffs: > 1. Make results.py download the images themselves, calculate pixel diffs, and > provide them to the client (perhaps as inline image data, within the JSON file?) > 2. Make the client download the images into Canvas elements, and then calculate > the pixel diffs as the user scrolls to them. This has several advantages > (including making it possible to do nifty effects like a loupe), but due to > security constraints requires the images to be loaded from the same domain as > the JSON results themselves. > > My intent is to add a new dispatcher to server.py : if the client requests > /images/gm/bitmap-64bitMD5/imageblur/5680959140053860741.png , fetch that file > from under http://chromium-skia-gm.commondatastorage.googleapis.com/ and return > it to the client. That will allow us to work around the security constraint, > and the client can perform Canvas operations on the fetched image data. Brian has changed my mind about this. I now think we are better off calculating pixel diffs on the server, mainly for reasons of client load/performance... if the viewer is using a phone browser, the phone might melt trying to calculate pixel diffs. We can perform them on the server side; if we see server load problems because multiple users are using the service concurrently, we should be able to amortize the work over multiple users (all users will see the same diffs, after all). In terms of how the client loads those pixel diff images... I guess the server's initial JSON response can include checksums of the diffs (similar to how it provides checksums of the expected/actual images themselves), and the client can construct an image source URL using the checksum. P.S. This does not preclude the option of loading images into a Canvas on the client later on... it may be appropriate to do that in some cases. Later. :-) borenet 2013/09/25 19:28:17 Yeah, #2 sounds awesome, particularly if you can d Show quoted text On 2013/09/25 18:26:33, epoger wrote: > On 2013/09/25 16:21:18, epoger wrote: > > On 2013/09/25 15:09:51, borenet wrote: > > > I don't know how useful they were to other devs, but I find myself missing > the > > > diff images. I'm aware that we aren't generating them any more though. > > > > Oh, absolutely. I added a TODO in lamenting this missing column. > > > > I can think of two ways of generating these pixel diffs: > > 1. Make results.py download the images themselves, calculate pixel diffs, and > > provide them to the client (perhaps as inline image data, within the JSON > file?) > > 2. Make the client download the images into Canvas elements, and then > calculate > > the pixel diffs as the user scrolls to them. This has several advantages > > (including making it possible to do nifty effects like a loupe), but due to > > security constraints requires the images to be loaded from the same domain as > > the JSON results themselves. > > > > My intent is to add a new dispatcher to server.py : if the client requests > > /images/gm/bitmap-64bitMD5/imageblur/5680959140053860741.png , fetch that file > > from under http://chromium-skia-gm.commondatastorage.googleapis.com/ and > return > > it to the client. That will allow us to work around the security constraint, > > and the client can perform Canvas operations on the fetched image data. > > Brian has changed my mind about this. I now think we are better off calculating > pixel diffs on the server, mainly for reasons of client load/performance... if > the viewer is using a phone browser, the phone might melt trying to calculate > pixel diffs. We can perform them on the server side; if we see server load > problems because multiple users are using the service concurrently, we should be > able to amortize the work over multiple users (all users will see the same > diffs, after all). > > In terms of how the client loads those pixel diff images... I guess the server's > initial JSON response can include checksums of the diffs (similar to how it > provides checksums of the expected/actual images themselves), and the client can > construct an image source URL using the checksum. > > P.S. This does not preclude the option of loading images into a Canvas on the > client later on... it may be appropriate to do that in some cases. Later. :-) Yeah, #2 sounds awesome, particularly if you can do neat things like set thresholds and have the diff regenerate on the fly, but it will likely be slow if the client is slow or if there are lots of images.
	39 </tr>

	40 <!-- TODO(epoger): improve the column sorting, as per

	41 http://jsfiddle.net/vojtajina/js64b/14/ -->

	42 <tr ng-repeat="result in results \| orderBy: sortColumn">

	43 <td>{{result.builder}}</td>

	44 <td>{{result.test}}</td>

	45 <td>{{result.config}}</td>

	46 <td>

	47 <a target="_blank" href="http://chromium-skia-gm.commondatastorage.g oogleapis.com/gm/{{result.expectedHashType}}/{{result.test}}/{{result.expectedHa shDigest}}.png">

	48 <img width="{{imageSize}}" src="http://chromium-skia-gm.commondata storage.googleapis.com/gm/{{result.expectedHashType}}/{{result.test}}/{{result.e xpectedHashDigest}}.png"/>

	49 </a>

	50 </td>

	51 <td>

	52 <a target="_blank" href="http://chromium-skia-gm.commondatastorage.g oogleapis.com/gm/{{result.actualHashType}}/{{result.test}}/{{result.actualHashDi gest}}.png">

	53 <img width="{{imageSize}}" src="http://chromium-skia-gm.commondata storage.googleapis.com/gm/{{result.actualHashType}}/{{result.test}}/{{result.act ualHashDigest}}.png"/>

	54 </a>

	55 </td>

	56 </tr>

	57 </table>

	58 </div>

	59

	60 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and

	61 issues list) from

	62 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json

	63 ? I tried importing the

	64 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using

	65 that to do so, but I got Access-Control-Allow-Origin errors.

	66 -->

	67

	68 </body>

	69 </html>

OLD	NEW

« gm/rebaseline_server/server.py ('K') | « gm/rebaseline_server/static/loader.js ('k') | gm/rebaseline_server/svn.py » ('j') | gm/rebaseline_server/svn.py » ('J')