Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2427363004:
Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. (Closed)
|
Created:
4 years, 2 months ago by horo Modified:
4 years, 1 month ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSpecify the base namespace of ::mojom in user_media_client_impl_unittest.cc.
When I introduced a forward declaration in content::mojom namespace in
content/common/service_worker/service_worker_types.h, I saw the following errors:
https://crrev.com/2410333006/#ps300001
--------------
./../content/renderer/media/user_media_client_impl_unittest.cc:79:3:
error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom';
did you mean '::mojom::MediaDevicesDispatcherHostPtr'?
mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
::mojom::MediaDevicesDispatcherHostPtr
gen/content/common/media/media_devices.mojom.h:134:7:
note: '::mojom::MediaDevicesDispatcherHostPtr' declared here
using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>;
^
../../content/renderer/media/user_media_client_impl_unittest.cc:84:17:
error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom';
did you mean '::mojom::MediaDevicesDispatcherHostStub'?
mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
::mojom::MediaDevicesDispatcherHostStub
gen/content/common/media/media_devices.mojom.h:205:7:
note: '::mojom::MediaDevicesDispatcherHostStub' declared here
class MediaDevicesDispatcherHostStub
^
--------------
TBR=mcasas@chromium.org
BUG=
Committed: https://crrev.com/e279a926d48d00dc72c1f22fc699c78448f3acfe
Cr-Commit-Position: refs/heads/master@{#426381}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 16 (12 generated)
Description was changed from ========== Specify the base name space of ::mojom. BUG= ========== to ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. BUG= ==========
horo@chromium.org changed reviewers: + mcasas@chromium.org
mcasas@ Please review this.
The CQ bit was checked by horo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. BUG= ========== to ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ BUG= ==========
Description was changed from ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ BUG= ========== to ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- BUG= ==========
Description was changed from ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- BUG= ========== to ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- TBR=mcasas@chromium.org BUG= ==========
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- TBR=mcasas@chromium.org BUG= ========== to ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- TBR=mcasas@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- TBR=mcasas@chromium.org BUG= ========== to ========== Specify the base namespace of ::mojom in user_media_client_impl_unittest.cc. When I introduced a forward declaration in content::mojom namespace in content/common/service_worker/service_worker_types.h, I saw the following errors: https://crrev.com/2410333006/#ps300001 -------------- ./../content/renderer/media/user_media_client_impl_unittest.cc:79:3: error: no type named 'MediaDevicesDispatcherHostPtr' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostPtr'? mojom::MediaDevicesDispatcherHostPtr CreateInterfacePtrAndBind() { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostPtr gen/content/common/media/media_devices.mojom.h:134:7: note: '::mojom::MediaDevicesDispatcherHostPtr' declared here using MediaDevicesDispatcherHostPtr = mojo::InterfacePtr<MediaDevicesDispatcherHost>; ^ ../../content/renderer/media/user_media_client_impl_unittest.cc:84:17: error: no template named 'MediaDevicesDispatcherHost' in namespace 'content::mojom'; did you mean '::mojom::MediaDevicesDispatcherHostStub'? mojo::Binding<mojom::MediaDevicesDispatcherHost> binding_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ::mojom::MediaDevicesDispatcherHostStub gen/content/common/media/media_devices.mojom.h:205:7: note: '::mojom::MediaDevicesDispatcherHostStub' declared here class MediaDevicesDispatcherHostStub ^ -------------- TBR=mcasas@chromium.org BUG= Committed: https://crrev.com/e279a926d48d00dc72c1f22fc699c78448f3acfe Cr-Commit-Position: refs/heads/master@{#426381} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e279a926d48d00dc72c1f22fc699c78448f3acfe Cr-Commit-Position: refs/heads/master@{#426381} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
