chrome/browser/engagement/site_engagement_service.h - Issue 2427343002: Make the site engagement service more robust to clock changes and time inconsistencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2427343002: Make the site engagement service more robust to clock changes and time inconsistencies. (Closed)

Patch Set: Cap last_engagement_time at now Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_service.h

diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h

index e7b463e9e1b864674b55b757b3e151e497e76e6d..4db77da9b4289c2c98bc540cb377267c6060606a 100644

--- a/chrome/browser/engagement/site_engagement_service.h

+++ b/chrome/browser/engagement/site_engagement_service.h

@@ -138,6 +138,10 @@ class SiteEngagementService : public KeyedService,

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CheckHistograms);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CleanupEngagementScores);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,

+ CleanupMovesScoreBackToNow);

+ FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,

+ CleanupMovesScoreBackToRebase);

+ FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,

CleanupEngagementScoresProportional);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, ClearHistoryForURLs);

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetMedianEngagement);