Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 242733005: Add a .gypi to insulate Chrome from refactorings in src/record. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
f(malita), mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add a .gypi to insulate Chrome from refactorings in src/record. Rather than listing out sources explicitly in skia_library.gypi, I'll add this new .gypi to its includes. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M gyp/record.gyp View 2 chunks +1 line, -6 lines 0 comments Download
A gyp/record.gypi View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
Sorry, one last small refactory CL.
6 years, 8 months ago (2014-04-21 15:45:14 UTC) #1
f(malita)
lgtm
6 years, 8 months ago (2014-04-21 15:45:59 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-21 15:46:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/242733005/1
6 years, 8 months ago (2014-04-21 15:46:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 15:46:20 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-21 15:46:20 UTC) #6
mtklein
lgtm
6 years, 8 months ago (2014-04-21 15:46:31 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 17:08:22 UTC) #8
Message was sent while issue was closed.
Change committed as 14282

Powered by Google App Engine
This is Rietveld 408576698