LayoutTests/editing/deleting/merge-list-items-in-same-list.html - Issue 242733004: canMergeLists() should make sure that the list items do not belong to the same list

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/deleting/merge-list-items-in-same-list.html

Issue 242733004: canMergeLists() should make sure that the list items do not belong to the same list (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE>
	yosin_UTC9 2014/04/22 04:42:52 nit: Please use "<!DOCTYPE html>" nit: Please use "<!DOCTYPE html>"
	2 <html>

	3 <body>

	4 <div>

	5 <ul contenteditable><li>one</li><li></li><li id="li">three</li></ul>

	6 </div>

	7 <script src="../../resources/dump-as-markup.js"></script>

	8 <script>

	9 var li = document.getElementById("li");
	yosin_UTC9 2014/04/22 04:42:52 nit: Please use single quote in JavaScript. https: nit: Please use single quote in JavaScript. https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Strings ojan 2014/04/30 01:59:59 For future reference, we don't use google style in Show quoted text On 2014/04/22 04:42:52, Yoshi wrote: > nit: Please use single quote in JavaScript. > https://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Strings For future reference, we don't use google style in layout test javascript. In practice, single or double quotes are both fine, although it's good to be consistent within any given test.
	10 var selection = window.getSelection();

	11 selection.collapse(li, 0);

	12 document.execCommand("Delete");

	13 Markup.dump(document.querySelector('div'));

	14 </script>

	15 </body>

	16 </html>

	17

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/deleting/merge-list-items-in-same-list-expected.txt » ('j') | Source/core/editing/htmlediting.cpp » ('J')