MD Settings: Migrate cups_printers_list.html to settings-action-menu.

chrome/browser/resources/settings/printing_page/cups_printers_list.js

Index: chrome/browser/resources/settings/printing_page/cups_printers_list.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_list.js b/chrome/browser/resources/settings/printing_page/cups_printers_list.js
index 6364807697e375a5ddacf40486c771d430c9aecc..007d16c14273b0cb5fabd8030fc053415164d2d7 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_list.js
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_list.js
@@ -19,6 +19,12 @@ Polymer({
     searchTerm: {
       type: String,
     },
+
+    /**
+     * The model for the printer action menu.
+     * @private {?CupsPrinterInfo}
+     */
+    activePrinter_: Object,
   },
 
   /** @private {settings.CupsPrintersBrowserProxy} */
@@ -30,6 +36,18 @@ Polymer({
   },
 
   /**
+   * @param {{model: {item: !CupsPrinterInfo}}} e

[michaelpg, 2016/10/20 18:00:39]

nit: more !s

[dpapad, 2016/10/20 18:15:57]

Done.

+   * @private
+   */
+  onDotsTap_: function(e) {
+    this.activePrinter_ = e.model.item;
+    var menu = /** @type {!SettingsActionMenuElement} */ (
+        this.$$('dialog[is=settings-action-menu]'));
+    menu.showAt(/** @type {!Element} */ (
+        Polymer.dom(/** @type {!Event} */ (e)).localTarget));
+  },
+
+  /**
    * @param {{model:Object}} event
    * @private
    */
@@ -37,7 +55,7 @@ Polymer({
     this.closeDropdownMenu_();
 
     // Event is caught by 'settings-printing-page'.
-    this.fire('show-cups-printer-details', event.model.item);
+    this.fire('show-cups-printer-details', this.activePrinter_);
   },
 
   /**
@@ -47,15 +65,17 @@ Polymer({
   onRemoveTap_: function(event) {
     this.closeDropdownMenu_();
 
-    var index = this.printers.indexOf(event.model.item);
+    var index = this.printers.indexOf(assert(this.activePrinter_));
     this.splice('printers', index, 1);
-    this.browserProxy_.removeCupsPrinter(event.model.item.printerId,
-                                         event.model.item.printerName);
+    this.browserProxy_.removeCupsPrinter(this.activePrinter_.printerId,
+                                         this.activePrinter_.printerName);

[michaelpg, 2016/10/20 18:00:39]

maybe set this.activePrinter_ = null; so it's not referencing a (soon-to-be)
removed printer?

[dpapad, 2016/10/20 18:15:57]

Updated closeDropdownMenu_ to set the activePrinter back to null, and moved the
calls at the end of onRemoveTap/onDetailsTap.

   },
 
   /** @private */
   closeDropdownMenu_: function() {
-    this.$$('iron-dropdown').close();
+    var menu = /** @type {!SettingsActionMenuElement} */ (
+        this.$$('dialog[is=settings-action-menu]'));
+    menu.close();
   },
 
   /**