Move the 'Exit session' button to the most left side in the system tray.

Move the 'Exit session' button to the most left side in the system tray.

BUG=657211
TEST=Using Linux,
- Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette --login-manager flags.
- Login to public session.
- Enable on-screen keyboard.
- Observe that the exit session button is on the most left side in the system tray.
- Observe that the popup shown on clicking stylus icon is aligned with the icon.
  This is also confirmed on normal session.

Committed: https://crrev.com/27f807d9af888c9db6236fd2adbb692112dcbd44
Cr-Commit-Position: refs/heads/master@{#431461}

[oka, 2016-10-19 04:11:10]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 04:12:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-10-19 04:12:55]

Description was changed from

==========
Move the 'Exit session' button to the most left side in the system tray.

TEST=Using Linux,
- Login to public session.
- Enable on-screen keyboard.
- Observe that the exit session button is on the left of the keyboard icon.

BUG=657211
==========

to

==========
Move the 'Exit session' button to the most left side in the system tray.

TEST=Using Linux,
1. Login to public session.
2. Enable on-screen keyboard.
3. Observe that the exit session button is on the left of the keyboard icon.

BUG=657211
==========

[oka, 2016-10-19 04:21:18]

oka@chromium.org changed reviewers:
+ stevenjb@chromium.org

[oka, 2016-10-19 04:24:44]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 04:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-10-19 04:30:50]

Description was changed from

==========
Move the 'Exit session' button to the most left side in the system tray.

TEST=Using Linux,
1. Login to public session.
2. Enable on-screen keyboard.
3. Observe that the exit session button is on the left of the keyboard icon.

BUG=657211
==========

to

==========
Move the 'Exit session' button to the most left side in the system tray.

TEST=Using Linux,
1. Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette
--login-manager flags.
2. Login to public session.
3. Enable on-screen keyboard.
4. Observe that the exit session button is on the most left side in the system
tray.

BUG=657211
==========

[commit-bot: I haz the power, 2016-10-19 09:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 09:54:03]

Dry run: This issue passed the CQ dry run.

[oka, 2016-10-20 02:19:37]

oka@chromium.org changed reviewers:
+ xiyuan@chromium.org
- stevenjb@chromium.org

[oka, 2016-10-20 02:19:38]

PTAL.

[xiyuan, 2016-10-20 15:54:00]

lgtm

You probably still need an ash OWNER's blessing.

[oka, 2016-11-07 03:32:12]

On 2016/10/20 15:54:00, xiyuan wrote:
> lgtm
> 
> You probably still need an ash OWNER's blessing.

I realized that the card opened on user's click is misaligned with the button.
How can I fix this?
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhUnJwdlZRb1BXblk/vie...

[xiyuan, 2016-11-07 17:25:02]

On 2016/11/07 03:32:12, oka wrote:
> On 2016/10/20 15:54:00, xiyuan wrote:
> > lgtm
> > 
> > You probably still need an ash OWNER's blessing.
> 
> I realized that the card opened on user's click is misaligned with the button.
> How can I fix this?
>
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhUnJwdlZRb1BXblk/vie...

PaletteTray::GetAnchorRect is probably where you can look at. It seems it was
compensating just the palette icon width, which assumes the icon left most. [1]

We probably want to change this to also include the position of the palette try,
e.g. change |icon_size| to icon's right edge tray_container()->right() (for
LTR).

[1]:
https://cs.chromium.org/chromium/src/ash/common/system/chromeos/palette/palet...

[oka, 2016-11-08 01:44:24]

On 2016/11/07 17:25:02, xiyuan wrote:
> On 2016/11/07 03:32:12, oka wrote:
> > On 2016/10/20 15:54:00, xiyuan wrote:
> > > lgtm
> > > 
> > > You probably still need an ash OWNER's blessing.
> > 
> > I realized that the card opened on user's click is misaligned with the
button.
> > How can I fix this?
> >
>
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhUnJwdlZRb1BXblk/vie...
> 
> PaletteTray::GetAnchorRect is probably where you can look at. It seems it was
> compensating just the palette icon width, which assumes the icon left most.
[1]
> 
> We probably want to change this to also include the position of the palette
try,
> e.g. change |icon_size| to icon's right edge tray_container()->right() (for
> LTR).
> 
> [1]:
>
https://cs.chromium.org/chromium/src/ash/common/system/chromeos/palette/palet...

TrayContainer doesn't have right() method.

[xiyuan, 2016-11-08 17:46:59]

On 2016/11/08 01:44:24, oka wrote:
> On 2016/11/07 17:25:02, xiyuan wrote:
> > On 2016/11/07 03:32:12, oka wrote:
> > > On 2016/10/20 15:54:00, xiyuan wrote:
> > > > lgtm
> > > > 
> > > > You probably still need an ash OWNER's blessing.
> > > 
> > > I realized that the card opened on user's click is misaligned with the
> button.
> > > How can I fix this?
> > >
> >
>
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhUnJwdlZRb1BXblk/vie...
> > 
> > PaletteTray::GetAnchorRect is probably where you can look at. It seems it
was
> > compensating just the palette icon width, which assumes the icon left most.
> [1]
> > 
> > We probably want to change this to also include the position of the palette
> try,
> > e.g. change |icon_size| to icon's right edge tray_container()->right() (for
> > LTR).
> > 
> > [1]:
> >
>
https://cs.chromium.org/chromium/src/ash/common/system/chromeos/palette/palet...
> 
> TrayContainer doesn't have right() method.

Right. We should use tray_container()->bounds().right() instead.

Give it a quick shot and found that tray_container() is the content view of
TrayBackgroundView. So its right() is the same as width(). Instead, we could
just use the x() of PaletteTray to achieve the right edge alignment.

i.e.
    r.Offset(-r.width() + icon_size, 0);
->  r.Offset(-r.width() + icon_size + x(), 0);

[oka, 2016-11-10 09:58:57]

On 2016/11/08 17:46:59, xiyuan wrote:
> On 2016/11/08 01:44:24, oka wrote:
> > On 2016/11/07 17:25:02, xiyuan wrote:
> > > On 2016/11/07 03:32:12, oka wrote:
> > > > On 2016/10/20 15:54:00, xiyuan wrote:
> > > > > lgtm
> > > > > 
> > > > > You probably still need an ash OWNER's blessing.
> > > > 
> > > > I realized that the card opened on user's click is misaligned with the
> > button.
> > > > How can I fix this?
> > > >
> > >
> >
>
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhUnJwdlZRb1BXblk/vie...
> > > 
> > > PaletteTray::GetAnchorRect is probably where you can look at. It seems it
> was
> > > compensating just the palette icon width, which assumes the icon left
most.
> > [1]
> > > 
> > > We probably want to change this to also include the position of the
palette
> > try,
> > > e.g. change |icon_size| to icon's right edge tray_container()->right()
(for
> > > LTR).
> > > 
> > > [1]:
> > >
> >
>
https://cs.chromium.org/chromium/src/ash/common/system/chromeos/palette/palet...
> > 
> > TrayContainer doesn't have right() method.
> 
> Right. We should use tray_container()->bounds().right() instead.
> 
> Give it a quick shot and found that tray_container() is the content view of
> TrayBackgroundView. So its right() is the same as width(). Instead, we could
> just use the x() of PaletteTray to achieve the right edge alignment.
> 
> i.e.
>     r.Offset(-r.width() + icon_size, 0);
> ->  r.Offset(-r.width() + icon_size + x(), 0);

That worked perfectly!
Please take a look again. Thanks.

[oka, 2016-11-10 11:33:03]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 11:33:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-11-10 12:02:29]

oka@chromium.org changed reviewers:
+ stevenjb@chromium.org

[oka, 2016-11-10 12:02:30]

PTAL.

[oka, 2016-11-10 12:04:18]

Description was changed from

==========
Move the 'Exit session' button to the most left side in the system tray.

TEST=Using Linux,
1. Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette
--login-manager flags.
2. Login to public session.
3. Enable on-screen keyboard.
4. Observe that the exit session button is on the most left side in the system
tray.

BUG=657211
==========

to

==========
Move the 'Exit session' button to the most left side in the system tray.

BUG=657211
TEST=Using Linux,
- Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette
--login-manager flags.
- Login to public session.
- Enable on-screen keyboard.
- Observe that the exit session button is on the most left side in the system
tray.
- Observe that the popup shown on clicking stylus icon is aligned with the icon.
  This is also confirmed on normal session.
==========

[xiyuan, 2016-11-10 16:49:24]

lgtm++

[oka, 2016-11-11 01:16:43]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[oka, 2016-11-11 01:17:03]

On 2016/11/10 16:49:24, xiyuan wrote:
> lgtm++

@stevenjb, could you grant owner approval?

[commit-bot: I haz the power, 2016-11-11 01:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-11-11 01:39:44]

lgtm

[commit-bot: I haz the power, 2016-11-11 01:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:54:42]

Dry run: This issue passed the CQ dry run.

[oka, 2016-11-11 01:58:52]

The CQ bit was checked by oka@chromium.org

[oka, 2016-11-11 01:59:05]

On 2016/11/11 01:39:44, stevenjb wrote:
> lgtm

Thank you!

[commit-bot: I haz the power, 2016-11-11 01:59:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 02:06:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 02:14:29]

Description was changed from

==========
Move the 'Exit session' button to the most left side in the system tray.

BUG=657211
TEST=Using Linux,
- Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette
--login-manager flags.
- Login to public session.
- Enable on-screen keyboard.
- Observe that the exit session button is on the most left side in the system
tray.
- Observe that the popup shown on clicking stylus icon is aligned with the icon.
  This is also confirmed on normal session.
==========

to

==========
Move the 'Exit session' button to the most left side in the system tray.

BUG=657211
TEST=Using Linux,
- Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette
--login-manager flags.
- Login to public session.
- Enable on-screen keyboard.
- Observe that the exit session button is on the most left side in the system
tray.
- Observe that the popup shown on clicking stylus icon is aligned with the icon.
  This is also confirmed on normal session.

Committed: https://crrev.com/27f807d9af888c9db6236fd2adbb692112dcbd44
Cr-Commit-Position: refs/heads/master@{#431461}
==========

[commit-bot: I haz the power, 2016-11-11 02:14:30]

Patchset 3 (id:??) landed as
https://crrev.com/27f807d9af888c9db6236fd2adbb692112dcbd44
Cr-Commit-Position: refs/heads/master@{#431461}