Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 24273002: Initialize ICU when running cctests. (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Initialize ICU when running cctests. This is required on Windows to load the ICU data tables. BUG=none R=machenbach@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/cctest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-19 10:55:57 UTC) #1
Michael Achenbach
On 2013/09/19 10:55:57, jochen wrote: lgtm
7 years, 3 months ago (2013-09-19 11:12:13 UTC) #2
jochen (gone - plz use gerrit)
+mstarzinger and here..
7 years, 3 months ago (2013-09-19 11:22:02 UTC) #3
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-19 11:31:35 UTC) #4
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-19 12:00:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r16825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698