ic: perform interceptor query in LookupForWrite

src/ic.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1589 matching lines @@
                            Handle<String> name,
                            Handle<Object> value,
                            LookupResult* lookup,
                            IC::State* state) {
   Handle<JSObject> holder = receiver;
   receiver->Lookup(*name, lookup);
   if (lookup->IsFound()) {
     if (lookup->IsReadOnly() || !lookup->IsCacheable()) return false;
 
     if (lookup->holder() == *receiver) {
-      if (lookup->IsInterceptor() &&
-          receiver->GetNamedInterceptor()->setter()->IsUndefined()) {
-        receiver->LocalLookupRealNamedProperty(*name, lookup);
-        return lookup->IsFound() &&
-            !lookup->IsReadOnly() &&
-            lookup->CanHoldValue(value) &&
-            lookup->IsCacheable();
+      if (lookup->IsInterceptor()) {
+        bool found_and_writable;
+        if (receiver->GetNamedInterceptor()->setter()->IsUndefined()) {
+          receiver->LocalLookupRealNamedProperty(*name, lookup);
+          found_and_writable = lookup->IsFound() &&
+                               !lookup->IsReadOnly() &&
+                               lookup->CanHoldValue(value);
+        } else {
+          ASSERT(lookup->representation()->IsNone());

[Toon Verwaest, 2013/09/23 13:09:59]

Why would the representation be none? It's explicitly set to Tagged in
InterceptorResult in src/property.h

+          PropertyAttributes attrs =
+              lookup->holder()->GetPropertyAttributeWithInterceptor(*receiver,
+                                                                    *name,
+                                                                    true);
+          found_and_writable = attrs != ABSENT && (attrs & READ_ONLY) == 0;
+        }
+        return found_and_writable && lookup->IsCacheable();
       }
       return lookup->CanHoldValue(value);
     }
 
     if (lookup->IsPropertyCallbacks()) return true;
 
     // Currently normal holders in the prototype chain are not supported. They
     // would require a runtime positive lookup and verification that the details
     // have not changed.
     if (lookup->IsInterceptor() || lookup->IsNormal()) return false;
@@ skipping 1529 matching lines @@
 #undef ADDR
 };
 
 
 Address IC::AddressFromUtilityId(IC::UtilityId id) {
   return IC_utilities[id];
 }
 
 
 } }  // namespace v8::internal