Issue 24272003: [DevTools] Blink-side APIs for device metrics emulation in content.

Issue 24272003: [DevTools] Blink-side APIs for device metrics emulation in content. (Closed)

Created:
7 years, 3 months ago by dgozman

Modified:
7 years, 2 months ago

Reviewers:
pfeldman

CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk/

Visibility:
Public.

More Reviews

Description

[DevTools] Blink-side APIs for device metrics emulation in content. BUG=288959 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158662

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Added new WebSetting #

Total comments: 2

Patch Set 5 : Comments #

Patch Set 6 : Comments #

Total comments: 2

Patch Set 7 : #

Patch Set 8 : Rebase #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
M	Source/core/page/Settings.in	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.h	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 2 3 4 5 6 7	1 chunk	+8 lines, -0 lines	0 comments	Download
M	public/web/WebDevToolsAgentClient.h	View	1 2 3 4 5 6	2 chunks	+13 lines, -0 lines	0 comments	Download
M	public/web/WebSettings.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	public/web/WebView.h	View	1 2 3 4 5 6 7	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

dgozman

Pavel, please take a look. Here are required API changes for https://codereview.chromium.org/23364004/ to work.

7 years, 3 months ago (2013-09-19 12:44:19 UTC) #1

pfeldman

See my comments to the other change - I believe it contains this one. https://codereview.chromium.org/24272003/diff/1/Source/web/WebViewImpl.h ...

7 years, 3 months ago (2013-09-19 12:48:10 UTC) #2

pfeldman

https://codereview.chromium.org/24272003/diff/20001/public/web/WebView.h File public/web/WebView.h (right): https://codereview.chromium.org/24272003/diff/20001/public/web/WebView.h#newcode402 public/web/WebView.h:402: const WebString& value) = 0; Please add comments to ...

7 years, 2 months ago (2013-10-01 14:41:41 UTC) #5

dgozman

PTAL https://codereview.chromium.org/24272003/diff/20001/public/web/WebView.h File public/web/WebView.h (right): https://codereview.chromium.org/24272003/diff/20001/public/web/WebView.h#newcode402 public/web/WebView.h:402: const WebString& value) = 0; On 2013/10/01 14:41:42, ...

7 years, 2 months ago (2013-10-01 14:48:18 UTC) #6

pfeldman

lgtm with a nit. https://codereview.chromium.org/24272003/diff/28001/public/web/WebDevToolsAgentClient.h File public/web/WebDevToolsAgentClient.h (right): https://codereview.chromium.org/24272003/diff/28001/public/web/WebDevToolsAgentClient.h#newcode95 public/web/WebDevToolsAgentClient.h:95: // Cancel emulation started via ...

7 years, 2 months ago (2013-10-01 14:50:15 UTC) #7

dgozman

Thanks for review https://codereview.chromium.org/24272003/diff/28001/public/web/WebDevToolsAgentClient.h File public/web/WebDevToolsAgentClient.h (right): https://codereview.chromium.org/24272003/diff/28001/public/web/WebDevToolsAgentClient.h#newcode95 public/web/WebDevToolsAgentClient.h:95: // Cancel emulation started via |enableDeviceEmulation| ...

7 years, 2 months ago (2013-10-01 15:22:56 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/24272003/33001

7 years, 2 months ago (2013-10-01 19:16:19 UTC) #9

commit-bot: I haz the power

Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7811

7 years, 2 months ago (2013-10-01 19:33:57 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/24272003/41001

7 years, 2 months ago (2013-10-01 21:41:39 UTC) #11

commit-bot: I haz the power

Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7828

7 years, 2 months ago (2013-10-01 21:57:44 UTC) #12

dgozman

7 years, 2 months ago (2013-10-01 22:09:42 UTC) #13

Message was sent while issue was closed.

Committed patchset #8 manually as r158662 (presubmit successful).

Expand Messages | Collapse Messages