Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2427133002: Revert of wptserve: Do not supress 'serve' command output on Windows. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
qyearsley, jsbell
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of wptserve: Do not supress 'serve' command output on Windows. (patchset #1 id:1 of https://codereview.chromium.org/2408133005/ ) Reason for revert: This diagnostic change isn't necessary any longer. Original issue's description: > wptserve: Do not supress 'serve' command output on Windows. > > BUG=623613 > > Committed: https://crrev.com/1a45e615bbeb1011695bca6259599ea61c26feb2 > Cr-Commit-Position: refs/heads/master@{#425060} TBR=qyearsley@chromium.org,jsbell@chromium.org NOTRY=true BUG=623613 Committed: https://crrev.com/0ab94e918f4ec8d13ff9951900829e31b1f38df5 Cr-Commit-Position: refs/heads/master@{#426112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
tkent
Created Revert of wptserve: Do not supress 'serve' command output on Windows.
4 years, 2 months ago (2016-10-19 00:21:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427133002/1
4 years, 2 months ago (2016-10-19 00:21:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427133002/1
4 years, 2 months ago (2016-10-19 00:22:36 UTC) #7
qyearsley
lgtm
4 years, 2 months ago (2016-10-19 00:23:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427133002/1
4 years, 2 months ago (2016-10-19 01:33:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 01:43:59 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ab94e918f4ec8d13ff9951900829e31b1f38df5
Cr-Commit-Position: refs/heads/master@{#426112}

Powered by Google App Engine
This is Rietveld 408576698