Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2427083002: Support subdomain matching in trial tokens (Closed)

Created:
4 years, 2 months ago by chasej
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Support subdomain matching in trial tokens This CL adds support for subdomain trial tokens, such that a properly issued token will enable a trial for multiple subdomains, rather than a single specified origin. In bug 653349, it was proposed to use a leading "*" to indicate a wildcard token (e.g. *.example.com). In this implementation, an explicit flag was added to the token format. The explicit flag keeping the token parsing simple, by keeping the url::Origin as the representation of the origin, and avoiding custom string parsing. BUG=653349 Review-Url: https://codereview.chromium.org/2411803002 Cr-Commit-Position: refs/heads/master@{#425168} (cherry picked from commit 4f0cb8e9b16a270d0a7fd313f161b4c2c9a0df29) Committed: https://chromium.googlesource.com/chromium/src/+/874cc8d1db06b6b7b04db41084f28a23956dbaf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -20 lines) Patch
M content/common/origin_trials/trial_token.h View 3 chunks +10 lines, -6 lines 0 comments Download
M content/common/origin_trials/trial_token.cc View 3 chunks +16 lines, -1 line 0 comments Download
M content/common/origin_trials/trial_token_unittest.cc View 10 chunks +125 lines, -2 lines 0 comments Download
M tools/origin_trials/generate_token.py View 6 chunks +31 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chasej
4 years, 2 months ago (2016-10-18 21:51:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
874cc8d1db06b6b7b04db41084f28a23956dbaf7.

Powered by Google App Engine
This is Rietveld 408576698