cros: Fixed 3 bugs for pin unlock.

ui/login/account_picker/screen_account_picker.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Account picker screen implementation.
  */
 
 login.createScreen('AccountPickerScreen', 'account-picker', function() {
   /**
@@ skipping 231 matching lines @@
      * @param {array} users Array of user.
      * @param {boolean} showGuest Whether to show guest session button.
      */
     loadUsers: function(users, showGuest) {
       $('pod-row').loadPods(users);
       $('login-header-bar').showGuestButton = showGuest;
       // On Desktop, #login-header-bar has a shadow if there are 8+ profiles.
       if (Oobe.getInstance().displayType == DISPLAY_TYPE.DESKTOP_USER_MANAGER)
         $('login-header-bar').classList.toggle('shadow', users.length > 8);
 
+      // Disable pin for users which should not be able to access pin. Such
+      // users include those who have not set up pin as those who have not
+      // entered their password recently.
+      for (var i in users) {

[jdufault, 2016/10/19 18:12:29]

Don't we usually do a for (var i = 0; i < users.length; ++i) {} loop? iirc, I
think there are subtle gotchas with this form.

[sammiequon, 2016/10/19 21:08:10]

Done.

+        if (!users[i].showPin)
+          this.disablePinKeyboardForUser(users[i].username);

[jdufault, 2016/10/19 18:12:29]

Why not put this inside of loadPinKeyboardIfNeeded_? Maybe rename that method to
initializePinKeyboardStateForUsers_?

[sammiequon, 2016/10/19 21:08:10]

Done.

+      }
+
       this.loadPinKeyboardIfNeeded_(users);
     },
 
     /**
      * Runs app with a given id from the list of loaded apps.
      * @param {!string} app_id of an app to run.
      * @param {boolean=} opt_diagnostic_mode Whether to run the app in
      *     diagnostic mode.  Default is false.
      */
     runAppForTesting: function(app_id, opt_diagnostic_mode) {
@@ skipping 159 matching lines @@
      * @param {string} userID The user ID of the public session
      * @param {string} locale The locale to which this list of keyboard layouts
      *     applies
      * @param {!Object} list List of available keyboard layouts
      */
     setPublicSessionKeyboardLayouts: function(userID, locale, list) {
       $('pod-row').setPublicSessionKeyboardLayouts(userID, locale, list);
     }
   };
 });