Issue 2427043002: VM: Remove unnecesary load of isolate in some stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2427043002: VM: Remove unnecesary load of isolate in some stubs. (Closed)

Created:
4 years, 2 months ago by Florian Schneider

Modified:
4 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Remove unnecesary load of isolate in some stubs. The fast-path allocation can always load the current heap from the thread object instead. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7e6d8f5b66145beb38e937a9e84a9eba37eecf29

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -16 lines)			Patch
M	runtime/vm/dart.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 2 months ago (2016-10-18 20:46:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e6d8f5b66145beb38e937a9e84a9eba37eecf29 (presubmit successful).