Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 242703002: Improve the handling of mock screen orientation for layout tests. (Closed)

Created:
6 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 8 months ago
Reviewers:
Inactive, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve the handling of mock screen orientation for layout tests. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M content/public/test/layouttest_support.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 3 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mlamouri (slow - plz ping)
6 years, 8 months ago (2014-04-18 16:35:56 UTC) #1
piman
lgtm
6 years, 8 months ago (2014-04-18 17:13:06 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 8 months ago (2014-04-18 17:30:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/242703002/1
6 years, 8 months ago (2014-04-18 17:30:35 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 18:26:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-18 18:26:08 UTC) #6
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 8 months ago (2014-04-18 18:30:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/242703002/1
6 years, 8 months ago (2014-04-18 18:30:41 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 20:20:22 UTC) #9
Message was sent while issue was closed. 
Change committed as 264841

Powered by Google App Engine
This is Rietveld 408576698