Revert of [Mac] Preserve original selection when suggesting completions with diacritics

Revert of [Mac] Preserve original selection when suggesting completions with diacritics (patchset #13 id:240001 of https://codereview.chromium.org/2395233005/ )

Reason for revert:
This almost definitely caused crbug.com/656972, but I can't repro the issue. Reverting while I investigate.

Original issue's description:
> Preserve original selection when suggesting completions with diacritics
>
> When NSTextView is asked to select a range which does not begin on a grapheme
> boundary, it expands the selection to the previous boundary. This change
> preserves the original selection, then contracts the range sent to
> NSTextView to fall on the *next* boundary.
>
> Text editing operations that operate on the selection use the original
> selection instead of the visual selection.
>
> Since the omnibox view uses the text view's selected range, the
> view's |selectedRange| returns the original range and not the visual
> range.
> BUG=603883
>
> Committed: https://crrev.com/8a8bae9fbc2e72afc208a0376c0f4a49388a6da3
> Cr-Commit-Position: refs/heads/master@{#425671}

TBR=asvitkine@chromium.org,erikchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603883
Committed: https://crrev.com/67434dc6fcbb9c1f734b147e75183d864b33f174
Cr-Commit-Position: refs/heads/master@{#425975}

[lgrey, 2016-10-18 15:22:30]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2016-10-18 15:22:31]

Created Revert of [Mac] Preserve original selection when suggesting completions
with diacritics

[commit-bot: I haz the power, 2016-10-18 15:22:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 15:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:22:45]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Alexei Svitkine (slow), 2016-10-18 15:24:04]

lgtm

[lgrey, 2016-10-18 15:24:44]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org

[lgrey, 2016-10-18 15:25:48]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:26:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 15:56:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-18 15:58:15]

Description was changed from

==========
Revert of [Mac] Preserve original selection when suggesting completions with
diacritics (patchset #13 id:240001 of
https://codereview.chromium.org/2395233005/ )

Reason for revert:
This almost definitely caused crbug.com/656972, but I can't repro the issue.
Reverting while I investigate.

Original issue's description:
> Preserve original selection when suggesting completions with diacritics
> 
> When NSTextView is asked to select a range which does not begin on a grapheme
> boundary, it expands the selection to the previous boundary. This change
> preserves the original selection, then contracts the range sent to
> NSTextView to fall on the *next* boundary.
> 
> Text editing operations that operate on the selection use the original
> selection instead of the visual selection.
> 
> Since the omnibox view uses the text view's selected range, the
> view's |selectedRange| returns the original range and not the visual
> range.
> BUG=603883
> 
> Committed: https://crrev.com/8a8bae9fbc2e72afc208a0376c0f4a49388a6da3
> Cr-Commit-Position: refs/heads/master@{#425671}

TBR=asvitkine@chromium.org,erikchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603883
==========

to

==========
Revert of [Mac] Preserve original selection when suggesting completions with
diacritics (patchset #13 id:240001 of
https://codereview.chromium.org/2395233005/ )

Reason for revert:
This almost definitely caused crbug.com/656972, but I can't repro the issue.
Reverting while I investigate.

Original issue's description:
> Preserve original selection when suggesting completions with diacritics
>
> When NSTextView is asked to select a range which does not begin on a grapheme
> boundary, it expands the selection to the previous boundary. This change
> preserves the original selection, then contracts the range sent to
> NSTextView to fall on the *next* boundary.
>
> Text editing operations that operate on the selection use the original
> selection instead of the visual selection.
>
> Since the omnibox view uses the text view's selected range, the
> view's |selectedRange| returns the original range and not the visual
> range.
> BUG=603883
>
> Committed: https://crrev.com/8a8bae9fbc2e72afc208a0376c0f4a49388a6da3
> Cr-Commit-Position: refs/heads/master@{#425671}

TBR=asvitkine@chromium.org,erikchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603883

Committed: https://crrev.com/67434dc6fcbb9c1f734b147e75183d864b33f174
Cr-Commit-Position: refs/heads/master@{#425975}
==========

[commit-bot: I haz the power, 2016-10-18 15:58:16]

Patchset 1 (id:??) landed as
https://crrev.com/67434dc6fcbb9c1f734b147e75183d864b33f174
Cr-Commit-Position: refs/heads/master@{#425975}