Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/test/base/testing_profile.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation of unit tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index 9d53560c57ad8b041693f9f147d935d116971a2d..a881fefd2fec9e7e46ffc40540914dd0707d9a02 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -494,9 +494,14 @@ void TestingProfile::DestroyTopSites() {
static KeyedService* BuildBookmarkModel(content::BrowserContext* context) {
Profile* profile = static_cast<Profile*>(context);
- BookmarkModel* bookmark_model = new BookmarkModel(profile);
- bookmark_model->Load(profile->GetIOTaskRunner());
- return bookmark_model;
+ ChromeBookmarkClient* bookmark_client = new ChromeBookmarkClient(profile);
+ bookmark_client->model()->Load(
+ profile->GetPrefs(),
+ profile->GetPath(),
+ profile->GetIOTaskRunner(),
+ content::BrowserThread::GetMessageLoopProxyForThread(
+ content::BrowserThread::UI));
+ return bookmark_client;
}
void TestingProfile::CreateBookmarkModel(bool delete_file) {
@@ -505,13 +510,14 @@ void TestingProfile::CreateBookmarkModel(bool delete_file) {
base::DeleteFile(path, false);
}
// This will create a bookmark model.
- BookmarkModel* bookmark_service = static_cast<BookmarkModel*>(
+ ChromeBookmarkClient* bookmark_client = static_cast<ChromeBookmarkClient*>(
BookmarkModelFactory::GetInstance()->SetTestingFactoryAndUse(
this, BuildBookmarkModel));
HistoryService* history_service =
HistoryServiceFactory::GetForProfileWithoutCreating(this);
if (history_service) {
+ BookmarkService* bookmark_service = bookmark_client->model();
history_service->history_backend_->bookmark_service_ = bookmark_service;
history_service->history_backend_->expirer_.bookmark_service_ =
bookmark_service;

Powered by Google App Engine
This is Rietveld 408576698