chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_storage.cc ('K') | « chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_win.cc » ('j') | components/bookmarks/core/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index 273a08d9a4e2cc319d7a6be7a350a5090d99bd95..6bac1713586e39ef3e1b0e343c1aa52944f3a30e 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -1162,7 +1162,7 @@ void BookmarkBarView::OnMenuButtonClicked(views::View* view,

node = model_->bookmark_bar_node()->GetChild(button_index);

}

- RecordBookmarkFolderOpen(GetBookmarkLaunchLocation());

+ RecordBookmarkFolderOpen(model_, GetBookmarkLaunchLocation());

bookmark_menu_ = new BookmarkMenuController(

browser_, page_navigator_, GetWidget(), node, start_index);

bookmark_menu_->set_observer(this);

@@ -1181,7 +1181,7 @@ void BookmarkBarView::ButtonPressed(views::Button* sender,

content::PAGE_TRANSITION_AUTO_BOOKMARK,

false);

page_navigator_->OpenURL(params);

- RecordBookmarkAppsPageOpen(GetBookmarkLaunchLocation());

+ RecordBookmarkAppsPageOpen(model_, GetBookmarkLaunchLocation());

return;

}

@@ -1206,7 +1206,7 @@ void BookmarkBarView::ButtonPressed(views::Button* sender,

disposition_from_event_flags, browser_->profile());

}

- RecordBookmarkLaunch(node, GetBookmarkLaunchLocation());

+ RecordBookmarkLaunch(model_, node, GetBookmarkLaunchLocation());

}

void BookmarkBarView::ShowContextMenuForView(views::View* source,