chrome/browser/history/history_backend_unittest.cc - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend_unittest.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_storage.cc ('K') | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/importer/profile_writer_unittest.cc » ('j') | components/bookmarks/core/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_backend_unittest.cc

diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc

index debfcd898941b2c2a9c0d013562a19959fe9fdfe..00e119563330cd6d13e4f5421795e1ee08fa5425 100644

--- a/chrome/browser/history/history_backend_unittest.cc

+++ b/chrome/browser/history/history_backend_unittest.cc

@@ -774,10 +774,10 @@ TEST_F(HistoryBackendTest, URLsNoLongerBookmarked) {

URLID row2_id = backend_->db_->GetRowForURL(row2.url(), NULL);

// Star the two URLs.

- bookmark_utils::AddIfNotBookmarked(&bookmark_model_, row1.url(),

- base::string16());

- bookmark_utils::AddIfNotBookmarked(&bookmark_model_, row2.url(),

- base::string16());

+ bookmark_utils::AddIfNotBookmarked(

+ &bookmark_model_, &bookmark_model_, row1.url(), base::string16());

+ bookmark_utils::AddIfNotBookmarked(

+ &bookmark_model_, &bookmark_model_, row2.url(), base::string16());

// Delete url 2. Because url 2 is starred this won't delete the URL, only

// the visits.

@@ -3132,7 +3132,7 @@ TEST_F(HistoryBackendTest, RemoveNotification) {

// Add a URL.

GURL url("http://www.google.com");

- bookmark_utils::AddIfNotBookmarked(model, url, base::string16());

+ bookmark_utils::AddIfNotBookmarked(model, model, url, base::string16());

HistoryService* service = HistoryServiceFactory::GetForProfile(

profile.get(), Profile::EXPLICIT_ACCESS);