chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_win.cc ('k') | components/bookmarks.gypi » ('j') | components/bookmarks/core/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

index 1954d032d78441c31cebcf37cb5de369bae4e8c6..913c55ca4f33ca2e8c403fe191b93332922764cd 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

@@ -138,7 +138,7 @@ void BookmarkMenuDelegate::ExecuteCommand(int id, int mouse_event_flags) {

chrome::OpenAll(parent_->GetNativeWindow(), page_navigator_, selection,

ui::DispositionFromEventFlags(mouse_event_flags),

profile_);

- RecordBookmarkLaunch(node, location_);

+ RecordBookmarkLaunch(GetBookmarkModel(), node, location_);

}

bool BookmarkMenuDelegate::ShouldExecuteCommandWithoutClosingMenu(