chrome/browser/ui/omnibox/omnibox_edit_model.cc - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/view_id_util_browsertest.mm ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | components/bookmarks/core/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

index c8278c14f710a34200ad76345c0c53096f009784..4d3f9a9329424105717076d8e6d93349bb673c7d 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

@@ -23,6 +23,8 @@

#include "chrome/browser/autocomplete/history_url_provider.h"

#include "chrome/browser/autocomplete/keyword_provider.h"

#include "chrome/browser/autocomplete/search_provider.h"

+#include "chrome/browser/bookmarks/bookmark_model.h"

+#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/bookmark_stats.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/command_updater.h"

@@ -827,8 +829,10 @@ void OmniboxEditModel::OpenMatch(AutocompleteMatch match,

}

- if (match.starred)

- RecordBookmarkLaunch(NULL, BOOKMARK_LAUNCH_LOCATION_OMNIBOX);

+ if (match.starred) {

+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile_);

+ RecordBookmarkLaunch(model, NULL, BOOKMARK_LAUNCH_LOCATION_OMNIBOX);

+ }

}

bool OmniboxEditModel::AcceptKeyword(EnteredKeywordModeMethod entered_method) {