chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 242693003: Introduce BookmarkClient interface to abstract embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm » ('j') | components/bookmarks/core/browser/bookmark_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index fe473f825b4e002ce60df0ee79b599247a1929d6..c73315a4de11831b53672cc827bfafbd6d843879 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -682,7 +682,7 @@ void RecordAppLaunch(Profile* profile, GURL url) {

if (!animate)

[self closeFolderAndStopTrackingMenus];

- RecordBookmarkLaunch(node, [self bookmarkLaunchLocation]);

+ RecordBookmarkLaunch(bookmarkModel_, node, [self bookmarkLaunchLocation]);

}

// Common function to open a bookmark folder of any type.

@@ -692,7 +692,7 @@ void RecordAppLaunch(Profile* profile, GURL url) {

// Only record the action if it's the initial folder being opened.

if (!showFolderMenus_)

- RecordBookmarkFolderOpen([self bookmarkLaunchLocation]);

+ RecordBookmarkFolderOpen(bookmarkModel_, [self bookmarkLaunchLocation]);

showFolderMenus_ = !showFolderMenus_;

if (sender == offTheSideButton_)

@@ -1229,7 +1229,7 @@ void RecordAppLaunch(Profile* profile, GURL url) {

WindowOpenDisposition disposition =

ui::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);

[self openURL:GURL(chrome::kChromeUIAppsURL) disposition:disposition];

- RecordBookmarkAppsPageOpen([self bookmarkLaunchLocation]);

+ RecordBookmarkAppsPageOpen(bookmarkModel_, [self bookmarkLaunchLocation]);

}

// To avoid problems with sync, changes that may impact the current