Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/bookmarks/bookmark_model.h

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model.h
diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h
index 70ca10aa8bc690757f9006207985ccea9435bc64..adef6159950d23cdbfeac359a35d6883a9e4fa22 100644
--- a/chrome/browser/bookmarks/bookmark_model.h
+++ b/chrome/browser/bookmarks/bookmark_model.h
@@ -19,8 +19,8 @@
#include "base/synchronization/waitable_event.h"
#include "base/task/cancelable_task_tracker.h"
#include "chrome/browser/bookmarks/bookmark_service.h"
+#include "components/bookmarks/core/browser/bookmark_client.h"
#include "components/bookmarks/core/browser/bookmark_node.h"
-#include "components/favicon_base/favicon_types.h"
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -40,10 +40,6 @@ namespace base {
class SequencedTaskRunner;
}
-namespace chrome {
-struct FaviconImageResult;
-}
-
// BookmarkModel --------------------------------------------------------------
// BookmarkModel provides a directed acyclic graph of URLs and folders.
@@ -55,12 +51,29 @@ struct FaviconImageResult;
// You should NOT directly create a BookmarkModel, instead go through the
// BookmarkModelFactory.
class BookmarkModel : public content::NotificationObserver,
+ public BookmarkClient,
public BookmarkService,
public KeyedService {
public:
explicit BookmarkModel(Profile* profile);
virtual ~BookmarkModel();
+ virtual base::CancelableTaskTracker::TaskId GetFaviconImageForURL(
+ const GURL& page_url,
+ int icon_types,
+ int desired_size_in_dip,
+ const FaviconImageCallback& callback,
+ base::CancelableTaskTracker* tracker) OVERRIDE;
+
+ virtual void ExtractBookmarkNodePairs(
+ const NodeSet& nodes,
+ NodeTypedCountPairs* node_typed_count_pairs) OVERRIDE;
+
+ virtual void RecordAction(const base::UserMetricsAction& action) OVERRIDE;
+
+ virtual bool PostTask(const tracked_objects::Location& from_here,
+ const base::Closure& task) OVERRIDE;
+
// Invoked prior to destruction to release any necessary resources.
virtual void Shutdown() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698