Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: components/bookmarks/core/browser/bookmark_client.h

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Work around STL android bug Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/bookmarks.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_BOOKMARKS_CORE_BROWSER_BOOKMARK_CLIENT_H_
6 #define COMPONENTS_BOOKMARKS_CORE_BROWSER_BOOKMARK_CLIENT_H_
7
8 #include <set>
9 #include <vector>
10
11 #include "base/callback.h"
12 #include "base/task/cancelable_task_tracker.h"
13
14 class GURL;
15 class BookmarkNode;
16
17 namespace base {
18 struct UserMetricsAction;
19 }
20
21 namespace favicon_base {
22 struct FaviconImageResult;
23 }
24
25 // This class abstracts operations that depends on the embedder's environment,
26 // e.g. Chrome.
27 class BookmarkClient {
28 public:
29 // Callback for GetFaviconImageForURL().
30 typedef base::Callback<void(const favicon_base::FaviconImageResult&)>
31 FaviconImageCallback;
32
33 // Types representing a set of BookmarkNode and a mapping from BookmarkNode
34 // to the number of time the corresponding URL has been typed by the user in
35 // the Omnibox.
36 typedef std::set<const BookmarkNode*> NodeSet;
37 typedef std::pair<const BookmarkNode*, int> NodeTypedCountPair;
38 typedef std::vector<NodeTypedCountPair> NodeTypedCountPairs;
39
40 // Requests the favicon of any of |icon_types| whose pixel sizes most
41 // closely match |desired_size_in_dip| (if value is 0, the largest favicon
42 // is returned) and desired scale factor for |page_url|. |callback| is run
43 // when the bits have been fetched. |icon_types| can be any combination of
44 // IconType value, but only one icon will be returned.
45 virtual base::CancelableTaskTracker::TaskId GetFaviconImageForURL(
46 const GURL& page_url,
47 int icon_types,
48 int desired_size_in_dip,
49 const FaviconImageCallback& callback,
50 base::CancelableTaskTracker* tracker) = 0;
51
52 // Returns true if the embedder supports typed count for URL.
53 virtual bool SupportsTypedCountForNodes() = 0;
54
55 // Retrieves the number of time each BookmarkNode URL has been typed in
56 // the Omnibox by the user.
57 virtual void GetTypedCountForNodes(
58 const NodeSet& nodes,
59 NodeTypedCountPairs* node_typed_count_pairs) = 0;
60
61 // Wrapper around RecordAction defined in base/metrics/user_metrics.h
62 // that ensure that the action is posted from the correct thread.
63 virtual void RecordAction(const base::UserMetricsAction& action) = 0;
64
65 // Notifies the history backend about urls of removed bookmarks.
66 // TODO(sdefresne): remove this method from the BookmarkClient (by having
67 // the client register itself as a BookmarkModelObserver if it is interested
68 // in the events), http://crbug.com/364433
69 virtual void NotifyHistoryAboutRemovedBookmarks(
70 const std::set<GURL>& removed_bookmark_urls) = 0;
71
72 protected:
73 virtual ~BookmarkClient() {}
74 };
75
76 #endif // COMPONENTS_BOOKMARKS_CORE_BROWSER_BOOKMARK_CLIENT_H_
OLDNEW
« no previous file with comments | « components/bookmarks.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698