Introduce BookmarkClient interface to abstract embedder

chrome/browser/bookmarks/bookmark_stats.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_STATS_H_

[sky, 2014/04/18 17:05:04]

Are you modifying this file in expectation of moving to components? I think it's
chrome specific and shouldn't need to move.

[sdefresne, 2014/04/18 22:25:49]

The function RecordBookmarkLaunch is currently used on iOS (with
BOOKMARK_LAUNCH_LOCATION_OMNIBOX).

I modified the file because I tried to remove all dependencies on content/ from
files that were in chrome/browser/bookmarks and were used by iOS. If you think
it is better not to move this file into the component, and I can revert the
corresponding changes.

I've reverted the changes for now, but we may have to consider how to handle
that dependency later.

 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_STATS_H_
 
+class BookmarkClient;
 class BookmarkNode;
 
 // This enum is used for the Bookmarks.EntryPoint histogram.
 enum BookmarkEntryPoint {
   BOOKMARK_ENTRY_POINT_ACCELERATOR,
   BOOKMARK_ENTRY_POINT_STAR_GESTURE,
   BOOKMARK_ENTRY_POINT_STAR_KEY,
   BOOKMARK_ENTRY_POINT_STAR_MOUSE,
 
   BOOKMARK_ENTRY_POINT_LIMIT // Keep this last.
@@ skipping 15 matching lines @@
   BOOKMARK_LAUNCH_LOCATION_WRENCH_MENU,
   // Bookmark manager.
   BOOKMARK_LAUNCH_LOCATION_MANAGER,
   // Autocomplete suggestion.
   BOOKMARK_LAUNCH_LOCATION_OMNIBOX,
 
   BOOKMARK_LAUNCH_LOCATION_LIMIT  // Keep this last.
 };
 
 // Records the launch of a bookmark for UMA purposes.
-void RecordBookmarkLaunch(const BookmarkNode* node,
+void RecordBookmarkLaunch(BookmarkClient* client,
+                          const BookmarkNode* node,
                           BookmarkLaunchLocation location);
 
 // Records the user opening a folder of bookmarks for UMA purposes.
-void RecordBookmarkFolderOpen(BookmarkLaunchLocation location);
+void RecordBookmarkFolderOpen(BookmarkClient* client,
+                              BookmarkLaunchLocation location);
 
 // Records the user opening the apps page for UMA purposes.
-void RecordBookmarkAppsPageOpen(BookmarkLaunchLocation location);
+void RecordBookmarkAppsPageOpen(BookmarkClient* client,
+                                BookmarkLaunchLocation location);
 
 #endif  // CHROME_BROWSER_BOOKMARKS_BOOKMARK_STATS_H_