Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/bookmarks/bookmark_stats.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_stats.h" 5 #include "chrome/browser/bookmarks/bookmark_stats.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "chrome/browser/bookmarks/bookmark_model.h" 8 #include "base/metrics/user_metrics.h"
9 #include "content/public/browser/user_metrics.h" 9 #include "components/bookmarks/core/browser/bookmark_client.h"
10 #include "components/bookmarks/core/browser/bookmark_node.h"
10 11
11 void RecordBookmarkLaunch(const BookmarkNode* node, 12 void RecordBookmarkLaunch(BookmarkClient* client,
13 const BookmarkNode* node,
12 BookmarkLaunchLocation location) { 14 BookmarkLaunchLocation location) {
13 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR || 15 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
14 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) { 16 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
15 content::RecordAction( 17 client->RecordAction(
16 base::UserMetricsAction("ClickedBookmarkBarURLButton")); 18 base::UserMetricsAction("ClickedBookmarkBarURLButton"));
17 } 19 }
18 UMA_HISTOGRAM_ENUMERATION( 20 UMA_HISTOGRAM_ENUMERATION(
19 "Bookmarks.LaunchLocation", location, BOOKMARK_LAUNCH_LOCATION_LIMIT); 21 "Bookmarks.LaunchLocation", location, BOOKMARK_LAUNCH_LOCATION_LIMIT);
20 22
21 if (!node) 23 if (!node)
22 return; 24 return;
23 25
24 // In the cases where a bookmark node is provided, record the depth of the 26 // In the cases where a bookmark node is provided, record the depth of the
25 // bookmark in the tree. 27 // bookmark in the tree.
26 int depth = 0; 28 int depth = 0;
27 for (const BookmarkNode* iter = node; iter != NULL; iter = iter->parent()) { 29 for (const BookmarkNode* iter = node; iter != NULL; iter = iter->parent()) {
28 depth++; 30 depth++;
29 } 31 }
30 // Record |depth - 2| to offset the invisible root node and permanent nodes 32 // Record |depth - 2| to offset the invisible root node and permanent nodes
31 // (Bookmark Bar, Mobile Bookmarks or Other Bookmarks) 33 // (Bookmark Bar, Mobile Bookmarks or Other Bookmarks)
32 UMA_HISTOGRAM_COUNTS("Bookmarks.LaunchDepth", depth - 2); 34 UMA_HISTOGRAM_COUNTS("Bookmarks.LaunchDepth", depth - 2);
33 } 35 }
34 36
35 void RecordBookmarkFolderOpen(BookmarkLaunchLocation location) { 37 void RecordBookmarkFolderOpen(BookmarkClient* client,
38 BookmarkLaunchLocation location) {
36 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR || 39 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
37 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) { 40 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
38 content::RecordAction( 41 client->RecordAction(base::UserMetricsAction("ClickedBookmarkBarFolder"));
39 base::UserMetricsAction("ClickedBookmarkBarFolder"));
40 } 42 }
41 } 43 }
42 44
43 void RecordBookmarkAppsPageOpen(BookmarkLaunchLocation location) { 45 void RecordBookmarkAppsPageOpen(BookmarkClient* client,
46 BookmarkLaunchLocation location) {
44 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR || 47 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
45 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) { 48 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
46 content::RecordAction( 49 client->RecordAction(
47 base::UserMetricsAction("ClickedBookmarkBarAppsShortcutButton")); 50 base::UserMetricsAction("ClickedBookmarkBarAppsShortcutButton"));
48 } 51 }
49 } 52 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698