Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/bookmarks/bookmark_model_factory.cc

Issue 242693003: Introduce BookmarkClient interface to abstract embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 5 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/deferred_sequenced_task_runner.h" 8 #include "base/deferred_sequenced_task_runner.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/browser/bookmarks/bookmark_model.h" 11 #include "chrome/browser/bookmarks/bookmark_model.h"
12 #include "chrome/browser/profiles/incognito_helpers.h" 12 #include "chrome/browser/profiles/incognito_helpers.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/profiles/startup_task_runner_service.h" 14 #include "chrome/browser/profiles/startup_task_runner_service.h"
15 #include "chrome/browser/profiles/startup_task_runner_service_factory.h" 15 #include "chrome/browser/profiles/startup_task_runner_service_factory.h"
16 #include "chrome/browser/undo/bookmark_undo_service.h" 16 #include "chrome/browser/undo/bookmark_undo_service.h"
17 #include "chrome/browser/undo/bookmark_undo_service_factory.h" 17 #include "chrome/browser/undo/bookmark_undo_service_factory.h"
18 #include "chrome/common/chrome_switches.h" 18 #include "chrome/common/chrome_switches.h"
19 #include "components/bookmarks/core/common/bookmark_pref_names.h" 19 #include "components/bookmarks/core/common/bookmark_pref_names.h"
20 #include "components/keyed_service/content/browser_context_dependency_manager.h" 20 #include "components/keyed_service/content/browser_context_dependency_manager.h"
21 #include "components/user_prefs/pref_registry_syncable.h" 21 #include "components/user_prefs/pref_registry_syncable.h"
22 #include "content/public/browser/browser_thread.h"
22 23
23 // static 24 // static
24 BookmarkModel* BookmarkModelFactory::GetForProfile(Profile* profile) { 25 BookmarkModel* BookmarkModelFactory::GetForProfile(Profile* profile) {
25 return static_cast<BookmarkModel*>( 26 return static_cast<BookmarkModel*>(
26 GetInstance()->GetServiceForBrowserContext(profile, true)); 27 GetInstance()->GetServiceForBrowserContext(profile, true));
27 } 28 }
28 29
29 BookmarkModel* BookmarkModelFactory::GetForProfileIfExists(Profile* profile) { 30 BookmarkModel* BookmarkModelFactory::GetForProfileIfExists(Profile* profile) {
30 return static_cast<BookmarkModel*>( 31 return static_cast<BookmarkModel*>(
31 GetInstance()->GetServiceForBrowserContext(profile, false)); 32 GetInstance()->GetServiceForBrowserContext(profile, false));
32 } 33 }
33 34
34 // static 35 // static
35 BookmarkModelFactory* BookmarkModelFactory::GetInstance() { 36 BookmarkModelFactory* BookmarkModelFactory::GetInstance() {
36 return Singleton<BookmarkModelFactory>::get(); 37 return Singleton<BookmarkModelFactory>::get();
37 } 38 }
38 39
39 BookmarkModelFactory::BookmarkModelFactory() 40 BookmarkModelFactory::BookmarkModelFactory()
40 : BrowserContextKeyedServiceFactory( 41 : BrowserContextKeyedServiceFactory(
41 "BookmarkModel", 42 "BookmarkModel",
42 BrowserContextDependencyManager::GetInstance()) { 43 BrowserContextDependencyManager::GetInstance()) {
43 } 44 }
44 45
45 BookmarkModelFactory::~BookmarkModelFactory() {} 46 BookmarkModelFactory::~BookmarkModelFactory() {}
46 47
47 KeyedService* BookmarkModelFactory::BuildServiceInstanceFor( 48 KeyedService* BookmarkModelFactory::BuildServiceInstanceFor(
48 content::BrowserContext* context) const { 49 content::BrowserContext* context) const {
49 Profile* profile = static_cast<Profile*>(context); 50 Profile* profile = static_cast<Profile*>(context);
50 BookmarkModel* bookmark_model = new BookmarkModel(profile); 51 BookmarkModel* bookmark_model = new BookmarkModel(profile);
51 bookmark_model->Load(StartupTaskRunnerServiceFactory::GetForProfile(profile)-> 52 bookmark_model->Load(StartupTaskRunnerServiceFactory::GetForProfile(profile)
52 GetBookmarkTaskRunner()); 53 ->GetBookmarkTaskRunner(),
54 content::BrowserThread::GetMessageLoopProxyForThread(
55 content::BrowserThread::UI));
53 #if !defined(OS_ANDROID) 56 #if !defined(OS_ANDROID)
54 if (CommandLine::ForCurrentProcess()->HasSwitch( 57 if (CommandLine::ForCurrentProcess()->HasSwitch(
55 switches::kEnableBookmarkUndo)) { 58 switches::kEnableBookmarkUndo)) {
56 bookmark_model->AddObserver( 59 bookmark_model->AddObserver(
57 BookmarkUndoServiceFactory::GetForProfile(profile)); 60 BookmarkUndoServiceFactory::GetForProfile(profile));
58 } 61 }
59 #endif // !defined(OS_ANDROID) 62 #endif // !defined(OS_ANDROID)
60 return bookmark_model; 63 return bookmark_model;
61 } 64 }
62 65
63 void BookmarkModelFactory::RegisterProfilePrefs( 66 void BookmarkModelFactory::RegisterProfilePrefs(
64 user_prefs::PrefRegistrySyncable* registry) { 67 user_prefs::PrefRegistrySyncable* registry) {
65 // Don't sync this, as otherwise, due to a limitation in sync, it 68 // Don't sync this, as otherwise, due to a limitation in sync, it
66 // will cause a deadlock (see http://crbug.com/97955). If we truly 69 // will cause a deadlock (see http://crbug.com/97955). If we truly
67 // want to sync the expanded state of folders, it should be part of 70 // want to sync the expanded state of folders, it should be part of
68 // bookmark sync itself (i.e., a property of the sync folder nodes). 71 // bookmark sync itself (i.e., a property of the sync folder nodes).
69 registry->RegisterListPref(prefs::kBookmarkEditorExpandedNodes, 72 registry->RegisterListPref(prefs::kBookmarkEditorExpandedNodes,
70 new base::ListValue, 73 new base::ListValue,
71 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 74 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
72 } 75 }
73 76
74 content::BrowserContext* BookmarkModelFactory::GetBrowserContextToUse( 77 content::BrowserContext* BookmarkModelFactory::GetBrowserContextToUse(
75 content::BrowserContext* context) const { 78 content::BrowserContext* context) const {
76 return chrome::GetBrowserContextRedirectedInIncognito(context); 79 return chrome::GetBrowserContextRedirectedInIncognito(context);
77 } 80 }
78 81
79 bool BookmarkModelFactory::ServiceIsNULLWhileTesting() const { 82 bool BookmarkModelFactory::ServiceIsNULLWhileTesting() const {
80 return true; 83 return true;
81 } 84 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698