Introduce BookmarkClient interface to abstract embedder

chrome/browser/bookmarks/bookmark_codec_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_codec.h"
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
+#include "chrome/browser/bookmarks/test_bookmark_client.h"
 #include "chrome/common/chrome_paths.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::ASCIIToUTF16;
 
 namespace {
 
 const char kUrl1Title[] = "url1";
 const char kUrl1Url[] = "http://www.url1.com";
 const char kUrl2Title[] = "url2";
@@ skipping 39 matching lines @@
   ASSERT_NO_FATAL_FAILURE(
       AssertNodesEqual(expected->mobile_node(), actual->mobile_node()));
 }
 
 }  // namespace
 
 class BookmarkCodecTest : public testing::Test {
  protected:
   // Helpers to create bookmark models with different data.
   BookmarkModel* CreateTestModel1() {
-    scoped_ptr<BookmarkModel> model(new BookmarkModel(NULL, false));
+    scoped_ptr<BookmarkModel> model(client_.CreateModel(false));
     const BookmarkNode* bookmark_bar = model->bookmark_bar_node();
     model->AddURL(bookmark_bar, 0, ASCIIToUTF16(kUrl1Title), GURL(kUrl1Url));
     return model.release();
   }
   BookmarkModel* CreateTestModel2() {
-    scoped_ptr<BookmarkModel> model(new BookmarkModel(NULL, false));
+    scoped_ptr<BookmarkModel> model(client_.CreateModel(false));
     const BookmarkNode* bookmark_bar = model->bookmark_bar_node();
     model->AddURL(bookmark_bar, 0, ASCIIToUTF16(kUrl1Title), GURL(kUrl1Url));
     model->AddURL(bookmark_bar, 1, ASCIIToUTF16(kUrl2Title), GURL(kUrl2Url));
     return model.release();
   }
   BookmarkModel* CreateTestModel3() {
-    scoped_ptr<BookmarkModel> model(new BookmarkModel(NULL, false));
+    scoped_ptr<BookmarkModel> model(client_.CreateModel(false));
     const BookmarkNode* bookmark_bar = model->bookmark_bar_node();
     model->AddURL(bookmark_bar, 0, ASCIIToUTF16(kUrl1Title), GURL(kUrl1Url));
     const BookmarkNode* folder1 = model->AddFolder(bookmark_bar, 1,
                                                    ASCIIToUTF16(kFolder1Title));
     model->AddURL(folder1, 0, ASCIIToUTF16(kUrl2Title), GURL(kUrl2Url));
     return model.release();
   }
 
   void GetBookmarksBarChildValue(base::Value* value,
                                  size_t index,
@@ skipping 66 matching lines @@
 
   BookmarkModel* DecodeHelper(const base::Value& value,
                               const std::string& expected_stored_checksum,
                               std::string* computed_checksum,
                               bool expected_changes) {
     BookmarkCodec decoder;
     // Computed and stored checksums should be empty.
     EXPECT_EQ("", decoder.computed_checksum());
     EXPECT_EQ("", decoder.stored_checksum());
 
-    scoped_ptr<BookmarkModel> model(new BookmarkModel(NULL, false));
+    scoped_ptr<BookmarkModel> model(client_.CreateModel(false));
     EXPECT_TRUE(Decode(&decoder, model.get(), value));
 
     *computed_checksum = decoder.computed_checksum();
     const std::string& stored_checksum = decoder.stored_checksum();
 
     // Computed and stored checksums should not be empty.
     EXPECT_FALSE(computed_checksum->empty());
     EXPECT_FALSE(stored_checksum.empty());
 
     // Stored checksum should be as expected.
@@ skipping 17 matching lines @@
     for (int i = 0; i < node->child_count(); ++i)
       CheckIDs(node->GetChild(i), assigned_ids);
   }
 
   void ExpectIDsUnique(BookmarkModel* model) {
     std::set<int64> assigned_ids;
     CheckIDs(model->bookmark_bar_node(), &assigned_ids);
     CheckIDs(model->other_node(), &assigned_ids);
     CheckIDs(model->mobile_node(), &assigned_ids);
   }
+
+  test::TestBookmarkClient client_;
 };
 
 TEST_F(BookmarkCodecTest, ChecksumEncodeDecodeTest) {
   scoped_ptr<BookmarkModel> model_to_encode(CreateTestModel1());
   std::string enc_checksum;
   scoped_ptr<base::Value> value(
       EncodeHelper(model_to_encode.get(), &enc_checksum));
 
   EXPECT_TRUE(value.get() != NULL);
 
@@ skipping 80 matching lines @@
                         GURL("http://newurl2.com"));
 
   ExpectIDsUnique(decoded_model.get());
 }
 
 TEST_F(BookmarkCodecTest, PersistIDsTest) {
   scoped_ptr<BookmarkModel> model_to_encode(CreateTestModel3());
   BookmarkCodec encoder;
   scoped_ptr<base::Value> model_value(encoder.Encode(model_to_encode.get()));
 
-  BookmarkModel decoded_model(NULL, false);
+  scoped_ptr<BookmarkModel> decoded_model(client_.CreateModel(false));
   BookmarkCodec decoder;
-  ASSERT_TRUE(Decode(&decoder, &decoded_model, *model_value.get()));
+  ASSERT_TRUE(Decode(&decoder, decoded_model.get(), *model_value.get()));
   ASSERT_NO_FATAL_FAILURE(
-      AssertModelsEqual(model_to_encode.get(), &decoded_model));
+      AssertModelsEqual(model_to_encode.get(), decoded_model.get()));
 
   // Add a couple of more items to the decoded bookmark model and make sure
   // ID persistence is working properly.
-  const BookmarkNode* bookmark_bar = decoded_model.bookmark_bar_node();
-  decoded_model.AddURL(
-      bookmark_bar, bookmark_bar->child_count(), ASCIIToUTF16(kUrl3Title),
-      GURL(kUrl3Url));
-  const BookmarkNode* folder2_node = decoded_model.AddFolder(
+  const BookmarkNode* bookmark_bar = decoded_model->bookmark_bar_node();
+  decoded_model->AddURL(bookmark_bar,
+                        bookmark_bar->child_count(),
+                        ASCIIToUTF16(kUrl3Title),
+                        GURL(kUrl3Url));
+  const BookmarkNode* folder2_node = decoded_model->AddFolder(
       bookmark_bar, bookmark_bar->child_count(), ASCIIToUTF16(kFolder2Title));
-  decoded_model.AddURL(folder2_node, 0, ASCIIToUTF16(kUrl4Title),
-                       GURL(kUrl4Url));
+  decoded_model->AddURL(
+      folder2_node, 0, ASCIIToUTF16(kUrl4Title), GURL(kUrl4Url));
 
   BookmarkCodec encoder2;
-  scoped_ptr<base::Value> model_value2(encoder2.Encode(&decoded_model));
+  scoped_ptr<base::Value> model_value2(encoder2.Encode(decoded_model.get()));
 
-  BookmarkModel decoded_model2(NULL, false);
+  scoped_ptr<BookmarkModel> decoded_model2(client_.CreateModel(false));
   BookmarkCodec decoder2;
-  ASSERT_TRUE(Decode(&decoder2, &decoded_model2, *model_value2.get()));
-  ASSERT_NO_FATAL_FAILURE(AssertModelsEqual(&decoded_model, &decoded_model2));
+  ASSERT_TRUE(Decode(&decoder2, decoded_model2.get(), *model_value2.get()));
+  ASSERT_NO_FATAL_FAILURE(
+      AssertModelsEqual(decoded_model.get(), decoded_model2.get()));
 }
 
 TEST_F(BookmarkCodecTest, CanDecodeModelWithoutMobileBookmarks) {
   base::FilePath test_data_directory;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory));
   base::FilePath test_file = test_data_directory.AppendASCII(
       "bookmarks/model_without_sync.json");
   ASSERT_TRUE(base::PathExists(test_file));
 
   JSONFileValueSerializer serializer(test_file);
   scoped_ptr<base::Value> root(serializer.Deserialize(NULL, NULL));
 
-  BookmarkModel decoded_model(NULL, false);
+  scoped_ptr<BookmarkModel> decoded_model(client_.CreateModel(false));
   BookmarkCodec decoder;
-  ASSERT_TRUE(Decode(&decoder, &decoded_model, *root.get()));
-  ExpectIDsUnique(&decoded_model);
+  ASSERT_TRUE(Decode(&decoder, decoded_model.get(), *root.get()));
+  ExpectIDsUnique(decoded_model.get());
 
-  const BookmarkNode* bbn = decoded_model.bookmark_bar_node();
+  const BookmarkNode* bbn = decoded_model->bookmark_bar_node();
   ASSERT_EQ(1, bbn->child_count());
 
   const BookmarkNode* child = bbn->GetChild(0);
   EXPECT_EQ(BookmarkNode::FOLDER, child->type());
   EXPECT_EQ(ASCIIToUTF16("Folder A"), child->GetTitle());
   ASSERT_EQ(1, child->child_count());
 
   child = child->GetChild(0);
   EXPECT_EQ(BookmarkNode::URL, child->type());
   EXPECT_EQ(ASCIIToUTF16("Bookmark Manager"), child->GetTitle());
 
-  const BookmarkNode* other = decoded_model.other_node();
+  const BookmarkNode* other = decoded_model->other_node();
   ASSERT_EQ(1, other->child_count());
 
   child = other->GetChild(0);
   EXPECT_EQ(BookmarkNode::FOLDER, child->type());
   EXPECT_EQ(ASCIIToUTF16("Folder B"), child->GetTitle());
   ASSERT_EQ(1, child->child_count());
 
   child = child->GetChild(0);
   EXPECT_EQ(BookmarkNode::URL, child->type());
   EXPECT_EQ(ASCIIToUTF16("Get started with Google Chrome"), child->GetTitle());
 
-  ASSERT_TRUE(decoded_model.mobile_node() != NULL);
+  ASSERT_TRUE(decoded_model->mobile_node() != NULL);
 }
 
 TEST_F(BookmarkCodecTest, EncodeAndDecodeMetaInfo) {
   // Add meta info and encode.
   scoped_ptr<BookmarkModel> model(CreateTestModel1());
   model->SetNodeMetaInfo(model->root_node(), "model_info", "value1");
   model->SetNodeMetaInfo(model->bookmark_bar_node()->GetChild(0),
                          "node_info", "value2");
   std::string checksum;
   scoped_ptr<base::Value> value(EncodeHelper(model.get(), &checksum));
@@ skipping 38 matching lines @@
 TEST_F(BookmarkCodecTest, CanDecodeMetaInfoAsString) {
   base::FilePath test_data_directory;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory));
   base::FilePath test_file = test_data_directory.AppendASCII(
       "bookmarks/meta_info_as_string.json");
   ASSERT_TRUE(base::PathExists(test_file));
 
   JSONFileValueSerializer serializer(test_file);
   scoped_ptr<base::Value> root(serializer.Deserialize(NULL, NULL));
 
-  BookmarkModel model(NULL, false);
+  scoped_ptr<BookmarkModel> model(client_.CreateModel(false));
   BookmarkCodec decoder;
-  ASSERT_TRUE(Decode(&decoder, &model, *root.get()));
+  ASSERT_TRUE(Decode(&decoder, model.get(), *root.get()));
 
-  EXPECT_EQ(1, model.root_node()->sync_transaction_version());
-  const BookmarkNode* bbn = model.bookmark_bar_node();
+  EXPECT_EQ(1, model->root_node()->sync_transaction_version());
+  const BookmarkNode* bbn = model->bookmark_bar_node();
   EXPECT_EQ(BookmarkNode::kInvalidSyncTransactionVersion,
             bbn->GetChild(0)->sync_transaction_version());
   EXPECT_EQ(42, bbn->GetChild(1)->sync_transaction_version());
 
   const char kSyncTransactionVersionKey[] = "sync.transaction_version";
   const char kNormalKey[] = "key";
   const char kNestedKey[] = "nested.key";
   std::string meta_value;
-  EXPECT_FALSE(model.root_node()->GetMetaInfo(kSyncTransactionVersionKey,
-                                               &meta_value));
+  EXPECT_FALSE(
+      model->root_node()->GetMetaInfo(kSyncTransactionVersionKey, &meta_value));
   EXPECT_FALSE(bbn->GetChild(1)->GetMetaInfo(kSyncTransactionVersionKey,
                                              &meta_value));
   EXPECT_TRUE(bbn->GetChild(0)->GetMetaInfo(kNormalKey, &meta_value));
   EXPECT_EQ("value", meta_value);
   EXPECT_TRUE(bbn->GetChild(1)->GetMetaInfo(kNormalKey, &meta_value));
   EXPECT_EQ("value2", meta_value);
   EXPECT_TRUE(bbn->GetChild(0)->GetMetaInfo(kNestedKey, &meta_value));
   EXPECT_EQ("value3", meta_value);
 }