Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: src/snapshot/serializer-common.cc

Issue 2426913002: Fix android build. (Closed)
Patch Set: actual include the include Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/serializer-common.cc
diff --git a/src/snapshot/serializer-common.cc b/src/snapshot/serializer-common.cc
index 6c400cd25ea2c9dfe1cd08a0c6bdf486e2bc8666..b1082f43587645c5e360eb78061f4ce67c2ed263 100644
--- a/src/snapshot/serializer-common.cc
+++ b/src/snapshot/serializer-common.cc
@@ -8,9 +8,10 @@
#include "src/ic/stub-cache.h"
#include "src/list-inl.h"
-#if defined(DEBUG) && defined(V8_OS_LINUX)
+#if defined(DEBUG) && defined(V8_OS_LINUX) && !defined(V8_OS_ANDROID)
+#define SYMBOLIZE_FUNCTION
#include <execinfo.h>
-#endif // DEBUG && V8_OS_LINUX
+#endif // DEBUG && V8_OS_LINUX && !V8_OS_ANDROID
namespace v8 {
namespace internal {
@@ -40,9 +41,9 @@ uint32_t ExternalReferenceEncoder::Encode(Address address) const {
if (entry == nullptr) {
void* function_addr = address;
v8::base::OS::PrintError("Unknown external reference %p.\n", function_addr);
-#if defined(DEBUG) && defined(V8_OS_LINUX)
+#ifdef SYMBOLIZE_FUNCTION
v8::base::OS::PrintError("%s\n", backtrace_symbols(&function_addr, 1)[0]);
-#endif // DEBUG && V8_OS_LINUX
+#endif // SYMBOLIZE_FUNCTION
v8::base::OS::Abort();
}
return static_cast<uint32_t>(reinterpret_cast<intptr_t>(entry->value));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698