Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_finder.cc

Issue 24269007: Media Galleries API: Fix MediaGalleriesPreferences finders race. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge origin Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/picasa_finder.cc
diff --git a/chrome/browser/media_galleries/fileapi/picasa_finder.cc b/chrome/browser/media_galleries/fileapi/picasa_finder.cc
index 86b4e12599bded872266e7ee7ac6e550588fe6de..6909ed38be976dc0262738e5b20b3023379d18a6 100644
--- a/chrome/browser/media_galleries/fileapi/picasa_finder.cc
+++ b/chrome/browser/media_galleries/fileapi/picasa_finder.cc
@@ -46,9 +46,12 @@ base::FilePath FindPicasaDatabaseOnFileThread() {
void FinishOnOriginalThread(const PicasaFinder::DeviceIDCallback& callback,
const base::FilePath& database_path) {
- if (!database_path.empty())
- callback.Run(StorageInfo::MakeDeviceId(StorageInfo::PICASA,
- database_path.AsUTF8Unsafe()));
+ std::string device_id;
+ if (!database_path.empty()) {
+ device_id = StorageInfo::MakeDeviceId(StorageInfo::PICASA,
+ database_path.AsUTF8Unsafe());
+ }
+ callback.Run(device_id);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698