Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: chrome/browser/ui/webui/options/media_galleries_handler.cc

Issue 24269007: Media Galleries API: Fix MediaGalleriesPreferences finders race. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/media_galleries_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/media_galleries_handler.cc
diff --git a/chrome/browser/ui/webui/options/media_galleries_handler.cc b/chrome/browser/ui/webui/options/media_galleries_handler.cc
index d42c3c9e3a63e1a9a1392c39054562d9fcffcf99..ea87cd0aaf89565999288e4d0ae97ab64dca6932 100644
--- a/chrome/browser/ui/webui/options/media_galleries_handler.cc
+++ b/chrome/browser/ui/webui/options/media_galleries_handler.cc
@@ -48,12 +48,15 @@ void MediaGalleriesHandler::GetLocalizedValues(DictionaryValue* values) {
}
void MediaGalleriesHandler::InitializePage() {
- StorageMonitor::GetInstance()->EnsureInitialized(
- base::Bind(&MediaGalleriesHandler::InitializeOnStorageMonitorInit,
- weak_ptr_factory_.GetWeakPtr()));
+ Profile* profile = Profile::FromWebUI(web_ui());
+ MediaGalleriesPreferences* preferences =
+ g_browser_process->media_file_system_registry()->GetPreferences(profile);
+ preferences->EnsureInitialized(base::Bind(
+ &MediaGalleriesHandler::InitializeOnMediaGalleriesPreferencesInit,
+ weak_ptr_factory_.GetWeakPtr()));
}
-void MediaGalleriesHandler::InitializeOnStorageMonitorInit() {
+void MediaGalleriesHandler::InitializeOnMediaGalleriesPreferencesInit() {
Profile* profile = Profile::FromWebUI(web_ui());
if (!MediaGalleriesPreferences::APIHasBeenUsed(profile))
return;
@@ -70,12 +73,15 @@ void MediaGalleriesHandler::InitializeOnStorageMonitorInit() {
}
void MediaGalleriesHandler::RegisterMessages() {
- StorageMonitor::GetInstance()->EnsureInitialized(
- base::Bind(&MediaGalleriesHandler::RegisterOnStorageMonitorInit,
- weak_ptr_factory_.GetWeakPtr()));
+ Profile* profile = Profile::FromWebUI(web_ui());
+ MediaGalleriesPreferences* preferences =
+ g_browser_process->media_file_system_registry()->GetPreferences(profile);
+ preferences->EnsureInitialized(base::Bind(
+ &MediaGalleriesHandler::RegisterOnPreferencesInit,
+ weak_ptr_factory_.GetWeakPtr()));
}
-void MediaGalleriesHandler::RegisterOnStorageMonitorInit() {
+void MediaGalleriesHandler::RegisterOnPreferencesInit() {
web_ui()->RegisterMessageCallback(
"addNewGallery",
base::Bind(&MediaGalleriesHandler::HandleAddNewGallery,
« no previous file with comments | « chrome/browser/ui/webui/options/media_galleries_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698