Media Galleries API: Fix MediaGalleriesPreferences finders race.

chrome/browser/media_galleries/fileapi/picasa_finder.cc

Index: chrome/browser/media_galleries/fileapi/picasa_finder.cc
diff --git a/chrome/browser/media_galleries/fileapi/picasa_finder.cc b/chrome/browser/media_galleries/fileapi/picasa_finder.cc
index 86b4e12599bded872266e7ee7ac6e550588fe6de..6909ed38be976dc0262738e5b20b3023379d18a6 100644
--- a/chrome/browser/media_galleries/fileapi/picasa_finder.cc
+++ b/chrome/browser/media_galleries/fileapi/picasa_finder.cc
@@ -46,9 +46,12 @@ base::FilePath FindPicasaDatabaseOnFileThread() {
 
 void FinishOnOriginalThread(const PicasaFinder::DeviceIDCallback& callback,
                             const base::FilePath& database_path) {
-  if (!database_path.empty())
-    callback.Run(StorageInfo::MakeDeviceId(StorageInfo::PICASA,
-                                           database_path.AsUTF8Unsafe()));
+  std::string device_id;
+  if (!database_path.empty()) {
+    device_id = StorageInfo::MakeDeviceId(StorageInfo::PICASA,
+                                          database_path.AsUTF8Unsafe());
+  }
+  callback.Run(device_id);

[Lei Zhang, 2013/09/20 23:55:28]

You need to update the FindPicasaDatabase() comment to reflect this new
behavior. FWIW, ITunesFinder does this too.

[tommycli, 2013/09/23 20:39:12]

Done.

 }
 
 }  // namespace