Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_dialog_controller.h

Issue 24269007: Media Galleries API: Fix MediaGalleriesPreferences finders race. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_
6 #define CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_ 6 #define CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 10
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 explicit MediaGalleriesDialogController( 106 explicit MediaGalleriesDialogController(
107 const extensions::Extension& extension); 107 const extensions::Extension& extension);
108 108
109 virtual ~MediaGalleriesDialogController(); 109 virtual ~MediaGalleriesDialogController();
110 110
111 private: 111 private:
112 // This type keeps track of media galleries already known to the prefs system. 112 // This type keeps track of media galleries already known to the prefs system.
113 typedef std::map<MediaGalleryPrefId, GalleryPermission> 113 typedef std::map<MediaGalleryPrefId, GalleryPermission>
114 KnownGalleryPermissions; 114 KnownGalleryPermissions;
115 115
116 // Bottom half of constructor -- called when the storage monitor 116 // Bottom half of constructor -- called when |preferences_| is initialized.
117 // is initialized. 117 void OnPreferencesInitialized();
118 void OnStorageMonitorInitialized();
119 118
120 // SelectFileDialog::Listener implementation: 119 // SelectFileDialog::Listener implementation:
121 virtual void FileSelected(const base::FilePath& path, 120 virtual void FileSelected(const base::FilePath& path,
122 int index, 121 int index,
123 void* params) OVERRIDE; 122 void* params) OVERRIDE;
124 123
125 // RemovableStorageObserver implementation. 124 // RemovableStorageObserver implementation.
126 // Used to keep dialog in sync with removable device status. 125 // Used to keep dialog in sync with removable device status.
127 virtual void OnRemovableStorageAttached(const StorageInfo& info) OVERRIDE; 126 virtual void OnRemovableStorageAttached(const StorageInfo& info) OVERRIDE;
128 virtual void OnRemovableStorageDetached(const StorageInfo& info) OVERRIDE; 127 virtual void OnRemovableStorageDetached(const StorageInfo& info) OVERRIDE;
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 189
191 // The view that's showing. 190 // The view that's showing.
192 scoped_ptr<MediaGalleriesDialog> dialog_; 191 scoped_ptr<MediaGalleriesDialog> dialog_;
193 192
194 scoped_refptr<ui::SelectFileDialog> select_folder_dialog_; 193 scoped_refptr<ui::SelectFileDialog> select_folder_dialog_;
195 194
196 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogController); 195 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogController);
197 }; 196 };
198 197
199 #endif // CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_ 198 #endif // CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698