Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_test_util.cc

Issue 24269007: Media Galleries API: Fix MediaGalleriesPreferences finders race. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media_galleries/media_galleries_test_util.h" 5 #include "chrome/browser/media_galleries/media_galleries_test_util.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 extensions::Blacklist::NOT_BLACKLISTED, 60 extensions::Blacklist::NOT_BLACKLISTED,
61 syncer::StringOrdinal::CreateInitialOrdinal()); 61 syncer::StringOrdinal::CreateInitialOrdinal());
62 ExtensionService* extension_service = 62 ExtensionService* extension_service =
63 extensions::ExtensionSystem::Get(profile)->extension_service(); 63 extensions::ExtensionSystem::Get(profile)->extension_service();
64 extension_service->AddExtension(extension.get()); 64 extension_service->AddExtension(extension.get());
65 extension_service->EnableExtension(extension->id()); 65 extension_service->EnableExtension(extension->id());
66 66
67 return extension; 67 return extension;
68 } 68 }
69 69
70 EnsureMediaDirectoriesExists::EnsureMediaDirectoriesExists() 70 TestMediaDirectoriesOverrides::TestMediaDirectoriesOverrides()
71 : num_galleries_(0) { 71 : num_galleries_(0) {
72 Init(); 72 Init();
73 } 73 }
74 74
75 EnsureMediaDirectoriesExists::~EnsureMediaDirectoriesExists() { 75 TestMediaDirectoriesOverrides::~TestMediaDirectoriesOverrides() {
76 } 76 }
77 77
78 void EnsureMediaDirectoriesExists::Init() { 78 void TestMediaDirectoriesOverrides::Init() {
79 #if defined(OS_CHROMEOS) || defined(OS_ANDROID) 79 #if defined(OS_CHROMEOS) || defined(OS_ANDROID)
80 return; 80 return;
81 #else 81 #else
82 82
83 ASSERT_TRUE(fake_dir_.CreateUniqueTempDir()); 83 ASSERT_TRUE(fake_dir_.CreateUniqueTempDir());
84 84
85 #if defined(OS_WIN) || defined(OS_MACOSX) 85 #if defined(OS_WIN) || defined(OS_MACOSX)
86 // This is to make sure the tests don't think iTunes is installed (unless 86 // This is to make sure the tests don't think iTunes is installed (unless
87 // we control it specifically). 87 // we control it specifically).
88 appdir_override_.reset(new base::ScopedPathOverride( 88 appdir_override_.reset(new base::ScopedPathOverride(
89 base::DIR_APP_DATA, fake_dir_.path().AppendASCII("itunes"))); 89 base::DIR_APP_DATA, fake_dir_.path().AppendASCII("itunes")));
90 #endif 90 #endif
91 91
92 music_override_.reset(new base::ScopedPathOverride( 92 music_override_.reset(new base::ScopedPathOverride(
93 chrome::DIR_USER_MUSIC, fake_dir_.path().AppendASCII("music"))); 93 chrome::DIR_USER_MUSIC, fake_dir_.path().AppendASCII("music")));
94 pictures_override_.reset(new base::ScopedPathOverride( 94 pictures_override_.reset(new base::ScopedPathOverride(
95 chrome::DIR_USER_PICTURES, fake_dir_.path().AppendASCII("pictures"))); 95 chrome::DIR_USER_PICTURES, fake_dir_.path().AppendASCII("pictures")));
96 video_override_.reset(new base::ScopedPathOverride( 96 video_override_.reset(new base::ScopedPathOverride(
97 chrome::DIR_USER_VIDEOS, fake_dir_.path().AppendASCII("videos"))); 97 chrome::DIR_USER_VIDEOS, fake_dir_.path().AppendASCII("videos")));
98 num_galleries_ = 3; 98 num_galleries_ = 3;
99 #endif 99 #endif
100 } 100 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698