Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/defaults.cc

Issue 24269003: Add methods to enable configuration of ResourceConstraints based on limits derived at runtime. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: /s/uintptr_t/uint64_t Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8.cc ('k') | src/globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --track-fields --track-double-fields --allow-natives-syntax 28 #include "../include/v8-defaults.h"
29 // Flags: --concurrent-recompilation --concurrent-recompilation-delay=100
30 29
31 if (!%IsConcurrentRecompilationSupported()) { 30 #include "platform.h"
32 print("Concurrent recompilation is disabled. Skipping this test."); 31 #include "globals.h"
33 quit(); 32 #include "v8.h"
33
34 namespace v8 {
35
36 bool ConfigureResourceConstraintsForCurrentPlatform(
37 ResourceConstraints* constraints) {
38 if (constraints == NULL) {
39 return false;
40 }
41
42 uint64_t physical_memory = i::OS::TotalPhysicalMemory();
43 uintptr_t lump_of_memory = (i::kPointerSize / 4) * i::MB;
44
45 // The young_space_size should be a power of 2 and old_generation_size should
46 // be a multiple of Page::kPageSize.
47 if (physical_memory > 2ul * i::GB) {
48 constraints->set_max_young_space_size(8 * lump_of_memory);
49 constraints->set_max_old_space_size(700 * lump_of_memory);
50 constraints->set_max_executable_size(256 * lump_of_memory);
51 } else if (physical_memory > 512ul * i::MB) {
52 constraints->set_max_young_space_size(4 * lump_of_memory);
53 constraints->set_max_old_space_size(192 * lump_of_memory);
54 constraints->set_max_executable_size(192 * lump_of_memory);
55 } else /* (physical_memory <= 512GB) */ {
56 constraints->set_max_young_space_size(1 * lump_of_memory);
57 constraints->set_max_old_space_size(96 * lump_of_memory);
58 constraints->set_max_executable_size(96 * lump_of_memory);
59 }
60 return true;
34 } 61 }
35 62
36 function new_object() { 63
37 var o = {}; 64 bool SetDefaultResourceConstraintsForCurrentPlatform() {
38 o.a = 1; 65 ResourceConstraints constraints;
39 o.b = 2; 66 if (!ConfigureResourceConstraintsForCurrentPlatform(&constraints))
40 return o; 67 return false;
68 return SetResourceConstraints(&constraints);
41 } 69 }
42 70
43 function add_field(obj) { 71 } // namespace v8::internal
44 obj.c = 3;
45 }
46
47 add_field(new_object());
48 add_field(new_object());
49 %OptimizeFunctionOnNextCall(add_field, "concurrent");
50
51 var o = new_object();
52 // Trigger optimization in the background thread.
53 add_field(o);
54 // Invalidate transition map while optimization is underway.
55 o.c = 2.2;
56 // Sync with background thread to conclude optimization that bailed out.
57 assertUnoptimized(add_field, "sync");
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698