Add methods to enable configuration of ResourceConstraints based on limits derived at runtime.

src/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 51 matching lines @@
 #endif
 
 namespace v8 {
 namespace internal {
 
 
 Heap::Heap()
     : isolate_(NULL),
 // semispace_size_ should be a power of 2 and old_generation_size_ should be
 // a multiple of Page::kPageSize.
 #if V8_TARGET_ARCH_X64

[Hannes Payer (out of office), 2013/09/24 07:31:00]

Let's get rid of this ifdef as well and use kPointerSize for the default
calculation below.

[rmcilroy, 2013/09/24 10:50:55]

Done.

 #define LUMP_OF_MEMORY (2 * MB)
       code_range_size_(512*MB),

[Hannes Payer (out of office), 2013/09/24 07:31:00]

Can we specify that in ConfigureResourceConstraintsForCurrentPlatform as well?

[rmcilroy, 2013/09/24 10:50:55]

ResourceConstraints doesn't have an option for setting code_range_size.  I'm not
sure if you want to expose that detail to the external API?

[Hannes Payer (out of office), 2013/09/24 11:27:16]

I like it how you handle it in your new cl.

 #else
 #define LUMP_OF_MEMORY MB
       code_range_size_(0),
 #endif
-#if defined(ANDROID) || V8_TARGET_ARCH_MIPS
-      reserved_semispace_size_(4 * Max(LUMP_OF_MEMORY, Page::kPageSize)),
-      max_semispace_size_(4 * Max(LUMP_OF_MEMORY, Page::kPageSize)),
-      initial_semispace_size_(Page::kPageSize),
-      max_old_generation_size_(192*MB),
-      max_executable_size_(max_old_generation_size_),
-#else
       reserved_semispace_size_(8 * Max(LUMP_OF_MEMORY, Page::kPageSize)),
       max_semispace_size_(8 * Max(LUMP_OF_MEMORY, Page::kPageSize)),
       initial_semispace_size_(Page::kPageSize),
       max_old_generation_size_(700ul * LUMP_OF_MEMORY),
       max_executable_size_(256l * LUMP_OF_MEMORY),

[Hannes Payer (out of office), 2013/09/24 07:31:00]

indent

[rmcilroy, 2013/09/24 10:50:55]

I'm not sure what you want indented here? The parameters are at the correct
indentation AFAIKS.

[Hannes Payer (out of office), 2013/09/24 11:27:16]

ups, looked strange on codereview, but it is correct.

-#endif
-
 // Variables set based on semispace_size_ and old_generation_size_ in
 // ConfigureHeap (survived_since_last_expansion_, external_allocation_limit_)
 // Will be 4 * reserved_semispace_size_ to ensure that young
 // generation can be aligned to its size.
       survived_since_last_expansion_(0),
       sweep_generation_(0),
       always_allocate_scope_depth_(0),
       linear_allocation_scope_depth_(0),
       contexts_disposed_(0),
       global_ic_age_(0),
@@ skipping 7982 matching lines @@
   if (FLAG_concurrent_recompilation) {
     heap_->relocation_mutex_->Lock();
 #ifdef DEBUG
     heap_->relocation_mutex_locked_by_optimizer_thread_ =
         heap_->isolate()->optimizing_compiler_thread()->IsOptimizerThread();
 #endif  // DEBUG
   }
 }
 
 } }  // namespace v8::internal