Add methods to enable configuration of ResourceConstraints based on limits derived at runtime.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 615 matching lines @@
   }
   if (constraints->is_memory_constrained().has_value &&
       !i::FLAG_force_memory_constrained.has_value) {
     isolate->set_is_memory_constrained(
         constraints->is_memory_constrained().value);
   }
   return true;
 }
 
 
+bool ConfigureResourceConstraintsForCurrentPlatform(

[Hannes Payer (out of office), 2013/09/24 07:31:00]

We had another discussion about that function right now... can we move it to a
separate file like v8-defaults.h? Adding it to the api is problematic for many
reasons, e.g., it hard to get rid of stuff added to the api.

[rmcilroy, 2013/09/24 10:50:55]

Done.  Kept the implementation here in api.cc though since that seems to be the
model with other split out includes (e.g., v8-testing.h, etc).

+    ResourceConstraints* constraints) {
+  if (constraints == NULL) {
+    return false;
+  }
+

[Hannes Payer (out of office), 2013/09/24 07:31:00]

Please add a comment which specifies the given configuration values, e.g., young
space has to be a power of 2 and old space has to be a multiple of
Page::kPageSize.

[rmcilroy, 2013/09/24 10:50:55]

Done.

+#if V8_TARGET_ARCH_X64
+  uintptr_t lump_of_memory = i::Max(2 * i::MB, i::Page::kPageSize);
+#else
+  uintptr_t lump_of_memory = i::Max(i::MB, i::Page::kPageSize);
+#endif
+
+  uintptr_t physical_memory = i::OS::TotalPhysicalMemory();
+  if (physical_memory > 2ul * i::GB) {
+    constraints->set_max_young_space_size(8 * lump_of_memory);
+    constraints->set_max_old_space_size(700 * lump_of_memory);
+    constraints->set_max_executable_size(256 * lump_of_memory);
+  } else if (physical_memory > 512ul * i::MB) {
+    constraints->set_max_young_space_size(4 * lump_of_memory);
+    constraints->set_max_old_space_size(192 * lump_of_memory);
+    constraints->set_max_executable_size(192 * lump_of_memory);
+  } else /* (physical_memory <= 512GB) */ {
+    constraints->set_max_young_space_size(1 * lump_of_memory);
+    constraints->set_max_old_space_size(96 * lump_of_memory);
+    constraints->set_max_executable_size(96 * lump_of_memory);
+  }
+  return true;
+}
+
+
+bool SetDefaultResourceConstraintsForCurrentPlatform() {
+  ResourceConstraints constraints;
+  if (!ConfigureResourceConstraintsForCurrentPlatform(&constraints))
+    return false;
+  return SetResourceConstraints(&constraints);
+}
+
+
 i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) {
   if (IsDeadCheck(isolate, "V8::Persistent::New")) return NULL;
   LOG_API(isolate, "Persistent::New");
   i::Handle<i::Object> result = isolate->global_handles()->Create(*obj);
 #ifdef DEBUG
   (*obj)->Verify();
 #endif  // DEBUG
   return result.location();
 }
 
@@ skipping 7239 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 } }  // namespace v8::internal