Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2426873002: ChromeOS: Add unittest for ConvertPathToArcUrl. (Closed)

Created:
4 years, 2 months ago by kinaba
Modified:
4 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org, Daniel Erat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Add unittest for ConvertPathToArcUrl. BUG=612720 TEST=unit_tests --gtest_filter='FileManagerPathUtilTest.ConvertPathToArcUrl' Committed: https://crrev.com/6b8f55438bb39e8cc37b76f97abf64683c476977 Cr-Commit-Position: refs/heads/master@{#425905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/path_util_unittest.cc View 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
kinaba
PTAL: fukino
4 years, 2 months ago (2016-10-18 05:32:26 UTC) #6
fukino
lgtm
4 years, 2 months ago (2016-10-18 05:38:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426873002/1
4 years, 2 months ago (2016-10-18 05:39:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 06:06:07 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b8f55438bb39e8cc37b76f97abf64683c476977 Cr-Commit-Position: refs/heads/master@{#425905}
4 years, 2 months ago (2016-10-18 06:08:34 UTC) #12
kinaba
4 years, 2 months ago (2016-10-18 07:05:03 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2429533004/ by kinaba@chromium.org.

The reason for reverting is: It broke a bot
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

Powered by Google App Engine
This is Rietveld 408576698