Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Issue 2426863003: Fix SKP version in tasks.json, make upload_skps.py update tasks.json (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SKP version in tasks.json, make upload_skps.py update tasks.json BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2426863003 Committed: https://skia.googlesource.com/skia/+/8a91da945929b08bfa916595cd1b70fd4341e007

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M infra/bots/tasks.json View 3 chunks +3 lines, -3 lines 0 comments Download
M infra/bots/upload_skps.py View 1 chunk +13 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
borenet
4 years, 2 months ago (2016-10-18 11:45:15 UTC) #3
rmistry
lgtm https://codereview.chromium.org/2426863003/diff/1/infra/bots/upload_skps.py File infra/bots/upload_skps.py (right): https://codereview.chromium.org/2426863003/diff/1/infra/bots/upload_skps.py#newcode65 infra/bots/upload_skps.py:65: 'git', 'add', os.path.join('infra', 'bots', 'tasks.json')]) I do not ...
4 years, 2 months ago (2016-10-18 11:49:14 UTC) #4
borenet
https://codereview.chromium.org/2426863003/diff/1/infra/bots/upload_skps.py File infra/bots/upload_skps.py (right): https://codereview.chromium.org/2426863003/diff/1/infra/bots/upload_skps.py#newcode65 infra/bots/upload_skps.py:65: 'git', 'add', os.path.join('infra', 'bots', 'tasks.json')]) On 2016/10/18 11:49:14, rmistry ...
4 years, 2 months ago (2016-10-18 11:58:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426863003/1
4 years, 2 months ago (2016-10-18 11:58:32 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 12:20:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8a91da945929b08bfa916595cd1b70fd4341e007

Powered by Google App Engine
This is Rietveld 408576698