Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2426843002: Generate an app snapshot even if the training run does a hard exit. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate an app snapshot even if the training run does a hard exit. (As the analyzer and pub do.) R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5ee94eb83783e4517922c4dfb85502d64eb3c515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M runtime/bin/isolate_data.h View 4 chunks +8 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M runtime/bin/process.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-10-18 00:41:10 UTC) #2
siva
lgtm
4 years, 2 months ago (2016-10-18 23:49:56 UTC) #3
rmacnak
4 years, 2 months ago (2016-10-19 16:37:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ee94eb83783e4517922c4dfb85502d64eb3c515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698