Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2426823003: Re-enable the QUIC v33 hacks. (Closed)

Created:
4 years, 2 months ago by Ryan Hamilton
Modified:
4 years, 2 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable the QUIC v33 hacks. protected by FLAGS_quic_remove_v33_hacks2 Effectively, this is rolling back internal change 132908836: Deprecate FLAGS_quic_remove_v33_hacks. BUG=655846, 655763 R=jri@chromium.org Committed: https://crrev.com/a6fc494d67bf62c40a8fc9eb515bdf27c772d2fb Cr-Commit-Position: refs/heads/master@{#426066}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase to tip of tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M net/quic/core/quic_flags_list.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 2 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Ryan Hamilton
4 years, 2 months ago (2016-10-18 21:08:53 UTC) #11
Jana
lgtm
4 years, 2 months ago (2016-10-18 21:11:36 UTC) #13
Jana
Can you correct the description?
4 years, 2 months ago (2016-10-18 21:12:37 UTC) #14
Ryan Hamilton
On 2016/10/18 21:12:37, Jana wrote: > Can you correct the description? Gah! Done.
4 years, 2 months ago (2016-10-18 21:15:34 UTC) #16
Ryan Hamilton
4 years, 2 months ago (2016-10-18 22:05:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a6fc494d67bf62c40a8fc9eb515bdf27c772d2fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698